fix(ci): tell gh which repository to upload the signatures to - #8
Merged
Conversation
The v0.2.0 release shipped WITHOUT its .sig files, and Colony's self-update
verifies signatures fail-closed - so that release cannot be installed or
updated to through the store.
The signing itself worked. The upload did not:
gh release upload "$TAG" dist/*.sig --clobber
failed to run git: fatal: not a git repository
The sign job deliberately has no `actions/checkout` - it downloads the built
assets rather than the source - so there is no git repository for `gh` to
infer the target from. The download step three lines above already passes
`-R "\${{ github.repository }}"`; the upload step was missed.
The failure mode is the worst kind: the job that exists to guarantee a release
is never published unsigned reported red only AFTER the release was published,
so it recorded the problem instead of preventing it.
All four Colony satellite repos carry the identical defect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.2.0 release shipped WITHOUT its .sig files, and Colony's self-update
verifies signatures fail-closed - so that release cannot be installed or
updated to through the store.
The signing itself worked. The upload did not:
The sign job deliberately has no
actions/checkout- it downloads the builtassets rather than the source - so there is no git repository for
ghtoinfer the target from. The download step three lines above already passes
-R "\${{ github.repository }}"; the upload step was missed.The failure mode is the worst kind: the job that exists to guarantee a release
is never published unsigned reported red only AFTER the release was published,
so it recorded the problem instead of preventing it.
All four Colony satellite repos carry the identical defect.