Repository navigation
Show the tour and the hotkey hint on the first launch - #13
Merged
Merged
Conversation
On a manual launch Rust shows the window and emits overlay:show before the interface has subscribed to it, so the event was lost: a fresh install never got the first-run tour, and a taken global hotkey was not reported at startup. get_settings now says whether the canvas is already visible, and the interface runs the same show handler itself. A hidden start (autostart) still waits for the event. Checked in the real app: a 22.04 AppImage built from this commit, on a clean system with no settings file, opens with the tour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while checking the 0.5.0 draft: a fresh install did not get the first-run tour.
Why. On a manual launch Rust shows the window and emits
overlay:showbeforemain.jshas subscribed to it, so the event is lost. The startup hint about a taken global hotkey was lost the same way (that one predates 0.5.0).Fix.
get_settingsreturnsvisible.startTouris guarded.Checked. In the real app: an Ubuntu 22.04 AppImage built from this branch, on a clean system with no settings file, opens with the tour (before the fix it did not).
npm run check,npm test, clippy andcargo testare clean.🤖 Generated with Claude Code