Repository navigation
Conversation
A fresh install now opens with the first-run tour, which dims the
screen, so the transparency check measured the dimming and failed on
macOS and Linux. Smoke tests write {"onboarded":true} before launching
(as for someone who took the tour) and check that the app itself wrote
installId into the file. On Windows the file is written without a BOM,
or serde would reject it and the settings would fall back to defaults.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rebuilt 0.5.0 draft failed the smoke test on macOS and both Linux runners: "the canvas is not transparent". This is expected — a fresh install now opens with the first-run tour (#13), which dims the screen, so the transparency check was measuring the dimming.
Fix.
{"onboarded":true}, as for someone who already took the tour.installIdinto the file.Checked. This workflow, run by hand against the v0.5.0 draft from this branch, passes on Windows, macOS, Ubuntu 22.04 and 24.04: https://github.com/ProAnima/Sketchover/actions/runs/40231263638
That the tour itself shows on a fresh install was checked separately, with the release AppImage on a clean Ubuntu 22.04.
🤖 Generated with Claude Code