Skip to content

Smoke tests start with the tour done - #14

Merged
Feargin merged 1 commit into
mainfrom
fix-smoke
Oct 25, 2026
Merged

Feargin merged 1 commit into
mainfrom
fix-smoke

Conversation

@Feargin

@Feargin Feargin commented Oct 25, 2026

Copy link
Copy Markdown
Collaborator

The rebuilt 0.5.0 draft failed the smoke test on macOS and both Linux runners: "the canvas is not transparent". This is expected — a fresh install now opens with the first-run tour (#13), which dims the screen, so the transparency check was measuring the dimming.

Fix.

  • Before launching, the smoke test writes {"onboarded":true}, as for someone who already took the tour.
  • "The app created its settings" becomes stricter: it checks that the app itself wrote installId into the file.
  • On Windows the file is written without a BOM; otherwise serde would reject it and the settings would fall back to defaults.

Checked. This workflow, run by hand against the v0.5.0 draft from this branch, passes on Windows, macOS, Ubuntu 22.04 and 24.04: https://github.com/ProAnima/Sketchover/actions/runs/40231263638

That the tour itself shows on a fresh install was checked separately, with the release AppImage on a clean Ubuntu 22.04.

🤖 Generated with Claude Code

A fresh install now opens with the first-run tour, which dims the
screen, so the transparency check measured the dimming and failed on
macOS and Linux. Smoke tests write {"onboarded":true} before launching
(as for someone who took the tour) and check that the app itself wrote
installId into the file. On Windows the file is written without a BOM,
or serde would reject it and the settings would fall back to defaults.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Feargin
Feargin merged commit 0988fc5 into main Oct 25, 2026
16 checks passed
@Feargin
Feargin deleted the fix-smoke branch October 25, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant