Skip to content

feat(notifications): add tabular-nums to numeric displays on NotificationsPanel (Closes #777) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(notifications): add tabular-nums to numeric displays on NotificationsPanel (Closes #777) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] #868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pages/NotificationsPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export default function NotificationsPanel({ maxItems }: NotificationsPanelProps
<p className="text-sm leading-6 text-muted-foreground">
{allRead
? "You're all caught up."
: `You have ${unreadCount} unread notification${unreadCount === 1 ? "" : "s"}.`}
: <>You have <span className="tabular-nums">{unreadCount}</span> unread notification{unreadCount === 1 ? "" : "s"}.</>}
</p>
</div>
{!allRead && (
Expand Down Expand Up @@ -198,15 +198,15 @@ export default function NotificationsPanel({ maxItems }: NotificationsPanelProps
<div className="mx-auto flex max-w-4xl items-center justify-between gap-4 px-4 py-3 sm:px-6 lg:max-w-5xl lg:px-8">
<div className="flex items-center gap-2 min-w-0">
<span className="text-sm text-muted-foreground whitespace-nowrap">
<span className="font-semibold text-foreground">{unreadCount}</span>
<span className="tabular-nums font-semibold text-foreground">{unreadCount}</span>
{" "}unread
</span>
<Badge
variant="secondary"
size="sm"
className="hidden shrink-0 sm:inline-flex"
>
{notifications.length} total
<span className="tabular-nums">{notifications.length}</span> total
</Badge>
</div>

Expand Down