feat(notifications): add tabular-nums to numeric displays on NotificationsPanel (Closes #777) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] - #868
Open
waterWang wants to merge 1 commit into
Conversation
…tionsPanel Apply font-variant-numeric: tabular-nums on amounts/counts so that digits align vertically during animation and live updates. Closes Predictify-org#777
|
@waterWang is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
font-variant-numeric: tabular-numsto numeric displays in NotificationsPanel so that digits align vertically during live updates and animation.Changes
{unreadCount}in a<span className="tabular-nums">for consistent digit alignmenttabular-numsto the unread count span in the sticky action bar{notifications.length}in a<span className="tabular-nums">Closes #777