ci(release-please): minor (0.12.0) not major — honor bump-minor-pre-major + Release-As - #377
Merged
Conversation
…pin 0.12.0 The release PR (PolusAI#344) proposed 1.0.0 because the workflow drove release-please-action@v4 with inline release-type/package-name, which put v4 on the non-manifest path and ignored release-please-config.json — where bump-minor-pre-major:true already asks for 0.x breaking changes to bump the minor (0.11.0 -> 0.12.0), not jump to 1.0.0. Switch to config-file/manifest-file so the policy is honored. Also pin this release explicitly via the footer below in case the config wiring needs a cycle to take effect. (The prior empty-commit Release-As in PolusAI#376 was dropped by rebase-merge and never reached main; this carries the footer on a real change so it survives any merge.) Release-As: 0.12.0 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the next release 0.12.0 (minor) instead of 1.0.0 (major), and fixes why it was major.
Root cause
release-please-config.jsonsetsbump-minor-pre-major: true(0.x breaking changes bump the minor, not jump to 1.0.0), but it was being ignored:.github/workflows/release-please.ymldroverelease-please-action@v4with inlinerelease-type/package-name, which puts v4 on the non-manifest path and skips the config file. So the omezarr z5/C++20 breaking change bumped0.11.0 → 1.0.0.What this does
config-file: release-please-config.json+manifest-file: .release-please-manifest.json(drops the inline inputs — they already live in the config). Nowbump-minor-pre-majoris honored → future 0.x breaking changes stay minor.Release-As: 0.12.0in the commit footer to pin this release to 0.12.0 regardless.Release-As: 0.12.0
Note
This supersedes #376, whose empty commit was dropped by rebase-merge (empty commits don't survive rebase) so its
Release-Asnever reachedmain. This commit has a real diff, so the footer survives any merge strategy.On merge, the Release Please workflow re-runs and rewrites #344 to
0.12.0.🤖 Generated with Claude Code