Skip to content

upload standalone .exe file for windows builds #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jw098 merged 1 commit into from
Aug 12, 2026
Merged

upload standalone .exe file for windows builds #1380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/cpp-ci-serial-programs-base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
with:
# Delete aqtsource once https://github.com/miurahr/aqtinstall/issues/1007 is fixed and released
aqtsource: 'git+https://github.com/miurahr/aqtinstall'
version: '6.11.1'
version: '6.10.2'
modules: 'qtmultimedia qtserialport'

- name: Install dependencies (Ubuntu)
Expand Down Expand Up @@ -107,6 +107,13 @@ jobs:
name: Serial Programs (os=${{inputs.os}} - compiler=${{inputs.compiler}})
path: ${{env.UPLOAD_FOLDER}}

- name: Upload Executable Only
uses: actions/upload-artifact@v7
if: inputs.upload-build && startsWith(inputs.os, 'windows')
with:
name: Standalone Executable (os=${{inputs.os}})
path: ${{env.UPLOAD_FOLDER}}/SerialPrograms.exe

@pifopi pifopi Aug 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to reuse the full folder with needed files, etc ?

@jw098 jw098 Aug 12, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the question. What are you suggesting?

Are you asking why I'm uploading the standalone .exe file, in addition to the full folder?

@pifopi pifopi Aug 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ! The exe file is included inside the folder that is already uploaded. And it has that and many more needed files (package, dll, etc) the only missing piece is dll for qt as they are very big and users might have a newer version locally!

@jw098 jw098 Aug 12, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thought was that the standalone .exe is easier to download since it's smaller. For people who already have CC downloaded, they can just drop in the standalone SerialPrograms.exe to replace the old old.

@pifopi pifopi Aug 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me ! It's likely they'd need up to date package though but that can be downloaded manually on the side !


- name: Checkout CommandLineTests
uses: actions/checkout@v7
if: inputs.run-tests
Expand Down
Loading