upload standalone .exe file for windows builds - #1380
Conversation
| if: inputs.upload-build && startsWith(inputs.os, 'windows') | ||
| with: | ||
| name: Standalone Executable (os=${{inputs.os}}) | ||
| path: ${{env.UPLOAD_FOLDER}}/SerialPrograms.exe |
There was a problem hiding this comment.
any reason not to reuse the full folder with needed files, etc ?
There was a problem hiding this comment.
I don't understand the question. What are you suggesting?
Are you asking why I'm uploading the standalone .exe file, in addition to the full folder?
There was a problem hiding this comment.
Yes ! The exe file is included inside the folder that is already uploaded. And it has that and many more needed files (package, dll, etc) the only missing piece is dll for qt as they are very big and users might have a newer version locally!
There was a problem hiding this comment.
My thought was that the standalone .exe is easier to download since it's smaller. For people who already have CC downloaded, they can just drop in the standalone SerialPrograms.exe to replace the old old.
There was a problem hiding this comment.
Works for me ! It's likely they'd need up to date package though but that can be downloaded manually on the side !
|
For mac and linux, I've tried in the past. Linux was working (=booting), mac I do not think so (but could not test). Not sure it's worth the pain with Koi's CI ? |
Uh oh!
There was an error while loading. Please reload this page.