fix BoxDraw so it doesn't crash if given improperly formatted string. Remove trailing zeros for FloatingPointWidget

Common/Cpp/PrettyPrint.cpp

@@ -174,6 +174,18 @@ std::string tostr_fixed(double x, int precision){
     return std::format("{:.{}f}", x, precision);
 }
 
+std::string tostr_fixed_no_trailing_zero(double x, int precision){
+    std::string str = std::format("{:.{}f}", x, precision);
+    if (str.find('.') != std::string::npos) {
+        str.erase(str.find_last_not_of('0') + 1, std::string::npos);
+        if (str.back() == '.') {
+            str.pop_back();
+        }
+    }
+    return str;
+}
+
+
 
 std::string now_to_filestring(){
 #if _WIN32 && _MSC_VER

Common/Cpp/PrettyPrint.h

@@ -23,6 +23,9 @@ std::string tostr_default(double x);
 // The precision specifies the number of digits after the decimal point.
 std::string tostr_fixed(double x, int precision);
 
+// Convert double to string with fixed precision, without trailing zeros.
+std::string tostr_fixed_no_trailing_zero(double x, int precision);
+
 // Format current time to a string to be used as filenames.
 // e.g. "20220320-044444408355"
 std::string now_to_filestring();

Common/Qt/Options/FloatingPointWidget.cpp

@@ -7,6 +7,7 @@
 #include <QHBoxLayout>
 #include <QLabel>
 #include <QLineEdit>
+#include "Common/Cpp/PrettyPrint.h"
 #include "ConfigWidget.h"
 #include "FloatingPointWidget.h"
 
@@ -69,7 +70,7 @@ FloatingPointCellWidget::FloatingPointCellWidget(QWidget& parent, FloatingPointC
     value.add_listener(*this);
 }
 void FloatingPointCellWidget::update_value(){
-    this->setText(QString::number(m_value, 'f'));
+    this->setText(QString::fromStdString(tostr_fixed_no_trailing_zero(m_value, 6)));
 }
 void FloatingPointCellWidget::on_config_value_changed(void* object){
     QMetaObject::invokeMethod(this, [this]{

SerialPrograms/Source/CommonFramework/Options/BoxOption.cpp

@@ -65,15 +65,25 @@ void BoxOption::on_config_value_changed(void* object){
         std::string box_coord_string = BOX_COORDINATES;
         std::vector<std::string> all_coords = StringTools::split(box_coord_string, ", ");
 
-        std::string x_string = all_coords[0];
-        std::string y_string = all_coords[1];
-        std::string width_string = all_coords[2];
-        std::string height_string = all_coords[3];
+        double x_coord = 0.0;
+        double y_coord = 0.0;
+        double width_coord = 0.0;
+        double height_coord = 0.0;
 
-        double x_coord = std::stod(x_string);
-        double y_coord = std::stod(y_string);
-        double width_coord = std::stod(width_string);
-        double height_coord = std::stod(height_string);
+        double* targets[] = { &x_coord, &y_coord, &width_coord, &height_coord };
+        size_t limit = std::min(all_coords.size(), size_t(4));
+
+        for (size_t i = 0; i < limit; ++i) {
+            const auto& s = all_coords[i];
+            char* endptr;
+            // Parses directly from the buffer without locale or exception overhead
+            double value = std::strtod(s.data(), &endptr);
+
+            // Validate that at least some characters were parsed successfully
+            if (endptr != s.data()) {
+                *targets[i] = value;
+            }
+        }
 
         // cout << box_coord_string << endl;
         // cout << std::to_string(x_coord) << endl;

SerialPrograms/Source/CommonFramework/Options/BoxOption.h

@@ -7,6 +7,7 @@
 #ifndef PokemonAutomation_BoxOption_H
 #define PokemonAutomation_BoxOption_H
 
+#include "Common/Cpp/PrettyPrint.h"
 #include "Common/Cpp/Options/GroupOption.h"
 #include "Common/Cpp/Options/FloatingPointOption.h"
 #include "Common/Cpp/Options/StringOption.h"
@@ -38,10 +39,10 @@ class BoxOption : public GroupOption, public ConfigOption::Listener{
 private:
     std::string make_full_str() const{
         return
-            std::to_string(X) + ", " +
-            std::to_string(Y) + ", " +
-            std::to_string(WIDTH) + ", " +
-            std::to_string(HEIGHT);
+            tostr_fixed_no_trailing_zero(double(X), 6) + ", " +
+            tostr_fixed_no_trailing_zero(double(Y), 6) + ", " +
+            tostr_fixed_no_trailing_zero(double(WIDTH), 6) + ", " +
+            tostr_fixed_no_trailing_zero(double(HEIGHT), 6);
     }
 
 public: