fix BoxDraw so it doesn't crash if given improperly formatted string. Remove trailing zeros for FloatingPointWidget - #1338
Merged
Conversation
… Remove trailing zeros for FloatingPointWidget
Mysticial
reviewed
Jul 25, 2026
| std::string tostr_fixed_no_trailing_zero(double x, int precision){ | ||
| std::string str = std::format("{:.{}f}", x, precision); | ||
| if (str.find('.') != std::string::npos) { | ||
| str.erase(str.find_last_not_of('0') + 1, std::string::npos); |
Collaborator
There was a problem hiding this comment.
Scientific notation isn't possible here right?
Collaborator
Author
There was a problem hiding this comment.
I believe so. I believe the F format doesn't use scientific notation. But the G format does.
Mysticial
approved these changes
Jul 25, 2026
Developer-Butters
pushed a commit
to Developer-Butters/Arduino-Source
that referenced
this pull request
Jul 28, 2026
… Remove trailing zeros for FloatingPointWidget (PokemonAutomation#1338) * fix BoxDraw so it doesn't crash if given improperly formatted string. Remove trailing zeros for FloatingPointWidget * fix build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.