Skip to content

Pin sdrf-pipelines 0.1.6 so /health reports a stable release - #5

Merged
selvaebi merged 3 commits into
PRIDE-Archive:mainfrom
nithujohn:pin-sdrf-pipelines-0.1.6
Aug 20, 2026
Merged

Pin sdrf-pipelines 0.1.6 so /health reports a stable release#5
selvaebi merged 3 commits into
PRIDE-Archive:mainfrom
nithujohn:pin-sdrf-pipelines-0.1.6

Conversation

@nithujohn

Copy link
Copy Markdown
Contributor

Summary

  • Pin sdrf-pipelines==0.1.6 instead of the unpinned git URL so /health reports a real release instead of whatever tag was latest at image-build time (production is still on 0.1.5).
  • 0.1.6 vendors the updated metaproteomics template: characteristics[environmental medium] is required and characteristics[environmental sample type] is no longer required.
  • Dockerfile comments no longer claim the image tracks sdrf-pipelines main HEAD.

Test plan

  • CI image build succeeds and installs sdrf-pipelines==0.1.6
  • After merge + kubectl rollout restart deployment/sdrf-validator -n sdrf-validator, GET /health returns "sdrf_pipelines_version": "0.1.6"
  • Metaproteomics SDRFs that have characteristics[environmental medium] and omit characteristics[environmental sample type] pass validation

nithujohn and others added 2 commits August 19, 2026 11:42
The unpinned git URL left production on 0.1.5, which still requires
characteristics[environmental sample type]. 0.1.6 vendors the updated
metaproteomics template (environmental medium required instead).

Co-authored-by: Cursor <cursoragent@cursor.com>
The fork push is blocked without the GitHub workflow OAuth scope; the
requirements pin and Dockerfile comment are enough for the version bump.

Co-authored-by: Cursor <cursoragent@cursor.com>
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d1203d1-23dd-4d1e-91e6-7bc46033206c


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread requirements.txt Outdated
# image vendors the matching sdrf-templates (0.1.6: environmental medium
# required; environmental sample type no longer required). An unpinned git
# URL reports whatever tag was latest at image-build time, which is why
# production is still on 0.1.5.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this line

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@selvaebi just to confirm, you want to remove line 10?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Updated sdrf-pipelines to version 0.1.6.
@selvaebi
selvaebi merged commit d1945d0 into PRIDE-Archive:main Aug 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants