Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Beep! I'm back with the goodies! 🍭I've aggregated the results of the automated checks for this PR below. 📡 Channel Compat — testingI've checked the pulse of your pull request. 💓 🚧 Channel unresolvable with this checkout — the repo's dependency floors exceed what the channel pins (fleet finding; see the install log). Constraints: https://raw.githubusercontent.com/OpenVoiceOS/OpenVoiceOS/main/constraints-testing.txt 🔒 Security (pip-audit)Scanning for any 'unauthenticated' access points. 🕵️ ✅ No known vulnerabilities found (72 packages scanned). 📡 Channel Compat — stableI've double-checked the data for any anomalies. 🔍 🚧 Channel unresolvable with this checkout — the repo's dependency floors exceed what the channel pins (fleet finding; see the install log). Constraints: https://raw.githubusercontent.com/OpenVoiceOS/OpenVoiceOS/main/constraints-stable.txt 📋 Repo HealthEnsuring the codebase isn't suffering from 'technical debt' flu. 🤒 ✅ All required files present. Latest Version: ✅ 🔍 LintAnalysis complete! Check out the details below. 📊 ❌ ruff: issues found — see job log ⚖️ License CheckChecking if the licenses are compatible with OVOS. 🧩 ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 📡 Channel Compat — alphaI've finished the digital walk-through of your PR. 🚶♂️ ✅ Test suite passes on the Constraints: https://raw.githubusercontent.com/OpenVoiceOS/OpenVoiceOS/main/constraints-alpha.txt 🔨 Build TestsEnsuring all components are in alignment. 📏 ✅ All versions pass
Closing the loop on this automated check ♻️ |
40653d3 to
f593eeb
Compare
Channel Compat checks the alpha channel, strictly, and nothing else. CI-only change.
What the removed rows were for, and where that coverage lives
The
stableandtestingrows asked "does a change that is green on dev still work on theversions the fleet actually runs". That question is real and it still needs answering. It is
answered in ovos-test-harness, which installs each channel's own stack rather than this
repository against a constraints file, and records the known gaps per channel in
test/channel_gaps/(269 node ids on stable, 184 on testing) so anything outside therecorded set turns the job red.
Do not reinstate these rows as "missing compat checks". They cannot work in this shape,
for a structural reason given below.
Why they cannot work here
A channel job installs this repository into one virtual environment alongside the channel's
pins. A released channel caps the very siblings dev already requires, so the resolve is
impossible:
Both rows died there on every run and reported green, because
soft_failconverted thefailure into a pass. They were not weak coverage; they were a green check for a comparison
that never ran, and no known-gap file could help because nothing was ever collected.
The harness avoids this by installing the channel's stack instead of this repository, which
is why the coverage belongs there and not here.
Why alpha is strict
Alpha sits at or ahead of dev, so it resolves and runs, and it is the channel the spec lands
in. A spec-adoption change that only works against current dev siblings has to fail
somewhere, and this is that place. The alpha constraints pin
ovos-spec-tools>=1.12.0a1,the first release whose migration map carries the OVOS-FALLBACK-1 renames, which is exactly
the kind of floor this row exists to hold.
Verification
The strict alpha row ran green in this repository's own CI. Locally, against
constraints-alpha.txtfetched from the same URL with the same extras: 718 passed, 22subtests, resolving ovos-bus-client 2.11.15a1 and ovos-spec-tools 1.12.0a1.
The matching change for ovos-core is in OpenVoiceOS/ovos-core#974.