ci: check the alpha channel strictly and drop the unresolvable rows - #974
Draft
JarbasAl wants to merge 1 commit into
Draft
ci: check the alpha channel strictly and drop the unresolvable rows#974JarbasAl wants to merge 1 commit into
JarbasAl wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Stand by... check results incoming! 📡I've aggregated the results of the automated checks for this PR below. 📋 Repo HealthEvaluating the longevity of the project. 🌳 ✅ All required files present. Latest Version: ✅ 🏷️ Release PreviewComing soon to a stable branch near you! 📽️ Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
📡 Channel Compat — stableChecking if we've met all our check criteria. ✅ 🚧 Channel unresolvable with this checkout — the repo's dependency floors exceed what the channel pins (fleet finding; see the install log). Constraints: https://raw.githubusercontent.com/OpenVoiceOS/OpenVoiceOS/main/constraints-stable.txt 📚 DocsAnalysis complete! Check out the details below. 📊 ✅ All required documentation files present. ✅ 🌍 Locale BuildHere's the lowdown on the latest automated check. 📉 ✅ Locale properly configured (65 files, 18 languages) Locale directories found:
Localization coverage:
pyproject.toml: ✅
Build manifest: ✅ 32 locale files included in package 📡 Channel Compat — testingAnalysis complete! Check out the details below. 📊 🚧 Channel unresolvable with this checkout — the repo's dependency floors exceed what the channel pins (fleet finding; see the install log). Constraints: https://raw.githubusercontent.com/OpenVoiceOS/OpenVoiceOS/main/constraints-testing.txt 🔒 Security (pip-audit)Checking for any insecure data transmissions. 📡 ✅ No known vulnerabilities found (113 packages scanned). 🔎 Type CheckI've checked the vitals of this contribution. 🩺 ❌ mypy: 367 error(s) found
Errors (showing first 10/367)🔌 Plugin DetectionChecking for any potential plugin conflicts. ⚔️ ❌ Plugin Status: ERRORS (1) Plugin Info:
OPM Detection:
Entry Point Validation:
⊘ No Issues:
📡 Channel Compat — alphaThe latest findings are now at your fingertips. ⌨️ ✅ Test suite passes on the Constraints: https://raw.githubusercontent.com/OpenVoiceOS/OpenVoiceOS/main/constraints-alpha.txt 📊 CoverageMeasuring the depth of our automated validation. 🌊 Files below 80% coverage (10 files)
Full report: download the 🔨 Build TestsA thorough inspection of the build process. 🔍 ✅ All versions pass
🔌 Skill Tests (ovoscope)Simulating real-world interactions with your skill. 🤖 ✅ 18/42 passed ✅ TestActiveHandlersOnlyIsNotPolled — 1/1 ❌ **TestAdaptIntent** — 0/4
❌ **TestCancelIntentMidSentence** — 0/1
❌ **TestConverse** — 0/1
❌ **TestDeactivate** — 2/3
❌ **TestFallback** — 0/1
❌ **TestIntentPipelineRouting** — 0/4
❌ **TestLangDisambiguation** — 0/4
❌ **TestLegacyIntentIdBackCompat** — 0/2
❌ **TestNoSkills** — 0/2
❌ **TestPadatiousIntent** — 0/4
🚌 Bus CoverageEnsuring no event path is left in the shadows. 🌑 🔴 Coverage Summary
📊 Per-Skill Breakdown
🔍 Detailed Message Type Breakdown
|
JarbasAl
changed the title
JarbasAl
force-pushed
the
ci/channel-compat-alpha-row
branch
from
September 9, 2026 12:03
4ea3d9a to
f48ef80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Channel Compat checks the alpha channel, strictly, and nothing else. CI-only change.
What the removed rows were for, and where that coverage lives
The
stableandtestingrows asked "does a change that is green on dev still work on theversions the fleet actually runs". That question is real and it still needs answering. It is
answered in ovos-test-harness, which installs each channel's own stack rather than this
repository against a constraints file, and records the known gaps per channel in
test/channel_gaps/(269 node ids on stable, 184 on testing) so anything outside therecorded set turns the job red.
Do not reinstate these rows as "missing compat checks". They cannot work in this shape,
for a structural reason given below.
Why they cannot work here
A channel job installs this repository into one virtual environment alongside the channel's
pins. A released channel caps the very siblings dev already requires, so the resolve is
impossible:
Both rows died there on every run and reported green, because
soft_failconverted thefailure into a pass. They were not weak coverage; they were a green check for a comparison
that never ran, and no known-gap file could help because nothing was ever collected.
The harness avoids this by installing the channel's stack instead of this repository, which
is why the coverage belongs there and not here.
Why alpha is strict
Alpha sits at or ahead of dev, so it resolves and runs, and it is the channel the spec lands
in. A spec-adoption change that only works against current dev siblings has to fail
somewhere, and this is that place. The alpha constraints pin
ovos-spec-tools>=1.12.0a1,the first release whose migration map carries the OVOS-FALLBACK-1 renames, which is exactly
the kind of floor this row exists to hold.
Verification
The strict alpha row ran green in this repository's own CI. Locally, against
constraints-alpha.txtfetched from the same URL with the same extras: 618 passed, 39subtests, resolving ovos-bus-client 2.11.15a1 and ovos-spec-tools 1.12.0a1.
The matching change for ovos-workshop is in OpenVoiceOS/ovos-workshop#625.