Conversation
ovoscope 1.8.1a1 made skill_id a required keyword-only argument of register_padatious_intent, register_padatious_entity and detach_intent (E2EPipelineHarness helpers) to enforce OVOS-INTENT-4 §3.1 attribution. Update the calls in test_ovoscope_e2e.py and test/end2end/test_intent4_consume_e2e.py accordingly and bump the ovoscope floor pin in the test extra. Fail-before: 12 e2e tests raised TypeError (missing skill_id) against unfixed test source with ovoscope 1.8.1a1 installed; all pass after the fix. Full suite: 172 passed, 3 pre-existing unrelated failures in test_nebulento.py (malformed-template tolerance, untouched by this change). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
I've combed through the code with a fine-tooth comb. 🔍I've aggregated the results of the automated checks for this PR below. 🔍 LintEverything looks good so far! ✅ ❌ ruff: issues found — see job log 🏷️ Release PreviewChecking for any potential release blockers. 🚧 Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
🔌 Plugin DetectionEnsuring the plugin's 'license' matches the manager's expectations. ⚖️ ❌ Plugin Status: ERRORS (1) Plugin Info:
OPM Detection:
Entry Point Validation:
⊘ No Issues:
📋 Repo HealthChecking for any cluttered files or folders. 🧹 ✅ All required files present. Latest Version: ✅ 📊 CoverageLet's see if we've left any dark corners in the test suite. 🔦 ✅ 91.6% total coverage Per-file coverage (7 files)
Full report: download the ⚖️ License CheckEnsuring our EULA (if any) is still valid. 📑 ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔌 Skill Tests (ovoscope)I've verified the skill's 'multi-turn' conversation logic. 🔄 ✅ 20/20 passed ✅ TestDetach — 2/2 🚌 Bus CoverageEnsuring the skill's internal gears are meshing correctly on the bus. ⚙️ 🔨 Build TestsThe build is fresh out of the oven! 🥯
❌ 3.10: Install OK, tests failed Your friendly neighborhood bot 🕷️ |
ovoscope 1.8.1a1 made
skill_ida required keyword-only argument on theE2EPipelineHarnesshelpers (register_padatious_intent,register_padatious_entity,detach_intent), enforcing OVOS-INTENT-4 §3.1 attribution. This repo's e2e tests called those helpers without it, so any environment with ovoscope 1.8.1a1 fails the suite withTypeError.The fix updates the calls in
test/test_ovoscope_e2e.pyandtest/end2end/test_intent4_consume_e2e.pyto passskill_id, and bumps theovoscopefloor pin in thetestextra to>=1.8.1a1.Verified with a fresh venv installing
ovoscope==1.8.1a1from PyPI: reverting only the test-file changes reproduced 12TypeErrorfailures; with the fix applied the full suite is 172 passed, 3 pre-existing failures unrelated to this change (malformed-template tolerance intest_nebulento.py, untouched by this PR).Separate finding, not addressed here:
nebulento/opm.py:389andnebulento/opm.py:512still readmessage.data.get("skill_id")/message.data["skill_id"]for registration/deregistration handling rather thanmessage.context["skill_id"], per OVOS-INTENT-4 §3.2 attribution.