fix: pass skill_id to ovoscope helpers and fix the malformed-template fixture - #53
openvoiceos-bot wants to merge 1 commit into
Conversation
… fixture Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The automated pipeline has reached its destination. 🏁I've aggregated the results of the automated checks for this PR below. 🏷️ Release PreviewI've checked the 'Breaking Changes' section for surprises. 💥 Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
⚖️ License CheckEvaluating the legal risk of these changes. ⚖️ ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔨 Build TestsThe build pipeline has finished its work. 🏁 ✅ All versions pass
🔌 Plugin DetectionEnsuring this plugin plays nice with others in the sandbox. 🏖️ ❌ Plugin Status: ERRORS (1) Plugin Info:
OPM Detection:
Entry Point Validation:
⊘ No Issues:
🔌 Skill Tests (ovoscope)Testing the skill's 'offline' capabilities (if any). 🔌 ✅ 20/20 passed ✅ TestDetach — 2/2 📊 CoverageCoverage report incoming! Every line counts. 🎯 ✅ 92.1% total coverage Per-file coverage (7 files)
Full report: download the 🔒 Security (pip-audit)Checking for any insecure data transmissions. 📡 ✅ No known vulnerabilities found (51 packages scanned). 🔍 LintI've finished the heavy lifting on this check. 🏋️♂️ ❌ ruff: issues found — see job log The inspector has left the building 🕵️ |
This PR clears two red checks that come from
dev:skill_ida required keyword-only argument on its registration helpers. Every call site here raisedTypeError: register_padatious_intent() missing 1 required keyword-only argument: 'skill_id'.TestMalformedTemplateTolerancetests fail. They used"cansad(e)"as a malformed template. OVOS-INTENT-1 §3.6 makes a single-branch group degenerate, not malformed, so ovos-spec-tools folds it to"cansade".This PR replaces #50, #51 and #52. Each of those PRs fixed one of the two reds and failed on the other.
What changed
test/test_ovoscope_e2e.py,test/end2end/test_intent4_consume_e2e.py: each helper call passes the skill that owns the registration.test/test_nebulento.py: the malformed fixture is now an unbalanced group,"cansad(e". A new test checks that"cansad(e)"folds to"cansade".nebulento/container.py: the docstring example is now the unbalanced group.pyproject.toml:ovos-spec-tools>=1.10.7a1, the floor that test: malformed-template fixture uses an unbalanced group #51 set for the folding behaviour.requirements.txt: removed. It copied thepyproject.tomldependencies with the oldovos-spec-tools>=1.5.0a1floor, and no build step reads it.Test
Local run on this tree (Python 3.11, prerelease resolution):
pytest testgives 176 passed.🤖 Generated with Claude Code