agent: add gk7605v100 - #143
Merged
Merged
Conversation
gk7605v100 shares the gk7205v200 memory map: the kernel device trees for the two differ only by two extra GPIO banks, with UART0 at 0x12040000, FMC at 0x10000000 (window 0x14000000), CRG 0x12010000, sysctrl 0x12020000 and the watchdog at 0x12030000 on both. It gets its own Makefile stanza, like gk7205v300, so `make SOC=gk7605v100` works, and it maps to the gk7205v200 build in _CHIP_TO_AGENT. The board has 256M of DDR, but the agent only maps the first 128 MiB from RAM_BASE. That is enough for every staging buffer it uses. Verified on a gk7605v100 board (sc2239, 256M, 8MB FM25Q64 NOR): make -C agent SOC=gk7605v100 # 18008 bytes defib agent upload -c gk7605v100 -p /dev/ttyUSB0 defib agent info -p /dev/ttyUSB0 defib agent read -p /dev/ttyUSB0 -o dump.bin Upload went through the boot ROM with the full U-Boot as SPL (boundary auto-detected) and reached READY. info reported JEDEC a14017, 8192 KB, 64 KB sectors, agent v4 with flash_stream/set_baud/scan/membw capabilities. The full 8 MiB read took 94 s at 89 KB/s, CRC32 OK. The dump is byte-identical to an independent U-Boot `sf read` + tftpput backup over boot+env, and to the OpenIPC lite release uImage and rootfs.squashfs over the kernel and rootfs partitions. Write paths were not exercised on this board.
PR Summary by QodoAdd gk7605v100 flash-agent support
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all |
The Profiles section now says 113 after the gk7605v100 profile; the protocol section still said 112.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flash-agent support for gk7605v100, which shares the gk7205v200 memory map. Its kernel DTS differs from gk7205v200's only by two extra GPIO banks; UART, FMC, CRG, sysctrl and watchdog are at the same addresses.
agent/Makefile:gk7605v100stanza (same as gk7205v300's), added to the supported listsrc/defib/agent/client.py:gk7605v100 → gk7205v200in_CHIP_TO_AGENTagent/README.md,CLAUDE.md: SoC table and counts (11 agent SoCs, 113 profiles after gk7605v100: add bootrom profile #142)Verification
make -C agent test HOST_CC=gcc: 5412/5412;make -C agent SOC=gk7605v100builds (18008 B)On hardware (gk7605v100, 256M, 8MB FM25Q64 NOR):
defib agent upload -c gk7605v100: bootrom → SPL → agent → READYdefib agent info: JEDECa14017, 8192 KB, 64 KB sectors, agent v4defib agent read: full 8 MiB in 94 s (89 KB/s), CRC32 OK. Byte-identical to an independent U-Bootsf read/tftpput backup over boot+env, and to the lite releaseuImage/rootfs.squashfsover kernel/rootfs.Write paths (
agent write/flash) were not exercised on this board.