chore(deps): bump markdown-it from 14.3.0 to 15.0.0 - #169
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6cdf939a1b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "katex": "^0.18.1", | ||
| "lucide-react": "^1.24.0", | ||
| "markdown-it": "^14.3.0", | ||
| "markdown-it": "^15.0.0", |
There was a problem hiding this comment.
Migrate markdown-it deep type imports before bumping
When installing this dependency set and running npm run typecheck/npm run build, the project still imports StateBlock, StateInline, and Token from markdown-it/lib/... in src/components/markdown-runtime.ts, but markdown-it 15 no longer exposes those internal subpaths and only publishes the bundled dist/root exports. With moduleResolution: "Bundler", those type-only deep imports become unresolved, so this version bump blocks the build unless the imports are moved to the public root exports (or the package stays on v14 until that migration is done).
Useful? React with 👍 / 👎.
Automated dependency review — markdown-it 14.3.0 → 15.0.0
|
Dependabot PR review — blocked by a breaking change ⛔ (not merged)Step 1 — Code review Step 2 — Regression verification — FAILED Decision (fail-fast): Not merging. This upgrade requires source-code changes to adapt Generated by Claude Code |
6cdf939 to
3c74f03
Compare
Automated dependency review — markdown-it 14.3.0 → 15.0.0 (major)Step 1 · Code review — ⛔ blocking issue found Step 2 · Regression verification — ❌ FAILED Root cause: markdown-it 15 changed how its default export is typed — Decision — not merging. Per fail-fast, this PR cannot be squash-merged as-is. It requires accompanying source changes to (Note: the Dependency audit red is a pre-existing/environmental advisory in the transitive Generated by Claude Code |
Automated Dependabot review —
|
3c74f03 to
f7e0b2e
Compare
Automated review — ❌ blocked at regression verification (fail-fast)Step 1 · Code review — The diff bumps Step 2 · Regression verification — FAILED. A fresh Root cause: markdown-it 15 ships its own bundled type definitions, which supersede the separately-installed This is a real, breaking API/type change, so it cannot land as a bare version bump. Decision: Per fail-fast, processing stops here and this PR is not merged. Recommended remediation (a small source migration, not a lockfile-only change):
Given it needs code changes and re-review, it's best handled as a dedicated follow-up rather than an auto-merge.
Generated by Claude Code |
Automated Dependabot review —
|
Bumps [markdown-it](https://github.com/markdown-it/markdown-it) from 14.3.0 to 15.0.0. - [Changelog](https://github.com/markdown-it/markdown-it/blob/master/CHANGELOG.md) - [Commits](markdown-it/markdown-it@14.3.0...15.0.0) --- updated-dependencies: - dependency-name: markdown-it dependency-version: 15.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
f7e0b2e to
26f5b1a
Compare
Automated review — held at Step 1 (not auto-merging)This is a major bump ( Breaking changes that affect this repoThe 15.0.0 changelog removes package-internal subpath exports ( import type StateBlock from "markdown-it/lib/rules_block/state_block.mjs";
import type StateInline from "markdown-it/lib/rules_inline/state_inline.mjs";
import type Token from "markdown-it/lib/token.mjs";Under v15 those paths no longer resolve, so Other v15 behavior changes worth validating before merge
RecommendationHandle as a dedicated change: bump + migrate the Generated by Claude Code |
Bumps markdown-it from 14.3.0 to 15.0.0.
Changelog
Sourced from markdown-it's changelog.
Commits
157b33b15..0.0 releasedf73cb76doc: rename files3bc8e2dAdd TS types2620dceUpdate contribution guidelines and issue templates7d365fedoc: migration info5c9b7ceUpdate changelog5a996d5doc: fix@exampletags displayf5083f4doc: continue restructuring & theme fixing54289c4Show inlinecodecontent in imagealttag #1142974e2d7text_joinrule fix: process imagealtcontent too (fixes lost escapes and...