chore(deps): bump react from 19.2.7 to 19.2.8 - #164
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34e9d18e84
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "mermaid": "^11.16.0", | ||
| "pixi.js": "^8.19.0", | ||
| "react": "^19.2.6", | ||
| "react": "^19.2.8", |
There was a problem hiding this comment.
Keep react-dom on the exact React version
With a fresh install from this lockfile, react resolves to 19.2.8 while react-dom remains pinned to 19.2.7. React 19's renderer compatibility check requires these packages to have exactly matching versions, so importing react-dom/client in src/main.tsx throws an incompatible-version error before either frontend renders. Upgrade react-dom and its lockfile entry to 19.2.8 alongside React.
Useful? React with 👍 / 👎.
Automated Dependabot reviewStep 1 — Code review
Steps 2 & 3 — Regression / CI
The audit/trivy failures are pre-existing on the base branch and unrelated to this bump. They reproduce across every open PR re-run today: the audit flags the Step 4 — Decision: not merged. Per fail-fast, I am not merging while required checks are red ( Generated by Claude Code |
Automated Dependabot review — ❌ not mergingStep 1 (code review) / Step 2 (regression): this bump introduces a real break, reproduced locally. React requires On this branch, Step 3 (CI): additionally, the required Dependency audit (prod, high+) and Container scan (trivy) checks are red repo-wide (pre-existing, unrelated to this bump). Decision: not merged. Generated by Claude Code |
Automated Dependabot review — not merged (fail-fast) ❌Scope: Blocking finding (Step 2 — regression): the required Verify check fails — this PR bumps only All 74 test files error at import of Recommended resolution: bump Generated by Claude Code |
Bumps [react](https://github.com/react/react/tree/HEAD/packages/react) from 19.2.7 to 19.2.8. - [Release notes](https://github.com/react/react/releases) - [Changelog](https://github.com/react/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/react/react/commits/v19.2.8/packages/react) --- updated-dependencies: - dependency-name: react dependency-version: 19.2.8 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
34e9d18 to
ef610f6
Compare
Dependabot PR review — blocked by a react/react-dom version mismatch ⛔ (not merged)Step 1 — Code review Step 2 — Regression verification — FAILED (fresh run against current This is a real, blocking regression, not a flake or stale base. Decision (fail-fast): Not merging. Generated by Claude Code |
|
·@·d·ependabot r·ebase Automated dependency review — react 19.2.7 → 19.2.8 (patch)Step 1 · Code review: Patch bump; release notes describe only a React Server Components decoding performance improvement (#37087). No API surface change; low risk for this browser app. Step 2 · Regression verification: The prior CI Verify run (July 25) failed, but its logs show Next: requested a rebase onto current Generated by Claude Code |
Automated dependency review — react 19.2.7 → 19.2.8
|
Step 2/3 · Regression verification on the rebased head — ❌ FAILEDAfter rebasing onto current
Decision — not merging. This bump must include a matching Generated by Claude Code |
Automated Dependabot review —
|
Automated Dependabot review —
|
Automated review — ❌ blocked at regression verification (fail-fast)Step 1 · Code review — The diff bumps Step 2 · Regression verification — FAILED. The required All 74 test files fail to import (React DOM throws "Incompatible React versions" / the testing-library render environment can't initialize) rather than any individual assertion failing. This is a genuine, deterministic breakage of the whole test + build surface, not flakiness. Decision: Per fail-fast, processing stops here and this PR is not merged. Recommended remediation: bump
Generated by Claude Code |
Automated review — Step 1 (Code review)
The branch was behind Generated by Claude Code |
Step 3 (CI) — ❌ FAILED, not mergingAfter updating the branch onto current This PR bumps only Fail-fast: stopping here, not merging. Fix required: bump Steps 1–2 (review + regression on the react patch itself) were otherwise clean; the blocker is purely the missing companion Generated by Claude Code |
Bumps react from 19.2.7 to 19.2.8.
Release notes
Sourced from react's releases.
Commits
1dd4ecb[FlightReply] Performance improvements when decoding (#37087)b0d2fdb[19.2.x] Update required references to GitHub repo (#36753)