zziplib: convert back to autotools build - #91260
Merged
Merged
Conversation
The cmake support in the v0.13.x branch is not very good. It heavily relies on add_custom_command and is fragile. The specific problem we ran into is that the install phase would not create some of the symlinks on darwin. This breaks reverse dependencies (e.g. texlive). Fixes: 4f701dd ('zziplib: 0.13.69 → 0.13.71')
Member
|
See also #91241 |
Member
Author
|
I don't think we should be working around bugs in the cmake build for the current release branch of zziplib. It would be much simpler to just stick with autotools build that is working now. We could add |
Member
Author
|
@GrahamcOfBorg build mpd texlive.bin.core-big |
Member
Author
|
@jtojnar Do you mind if we merge this? The problem has been reported upstream. It's unfortunate that I have to revert some of your work, but it should be easy enough to reinstate it, once upstream streamlines their cmake build. |
jtojnar
approved these changes
Jun 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cmake support in the v0.13.x branch is not very good. It heavily
relies on add_custom_command and is fragile.
The specific problem we ran into is that the install phase would not
create some of the symlinks on darwin. This breaks reverse
dependencies (e.g. texlive).
Fixes: 4f701dd ('zziplib: 0.13.69 → 0.13.71')
Motivation for this change
zziplib on darwin after #85147 is missing libzzip.dylib, libzzip.la, but provides libzzip-0.13.0.71.dylib:
This PR unbreaks
texlive.bin.core-bigon darwin.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)