Skip to content

zziplib: fix build on darwin - #91241

Closed
marsam wants to merge 1 commit into
NixOS:masterfrom
marsam:fix-zziplib-darwin
Closed

zziplib: fix build on darwin#91241
marsam wants to merge 1 commit into
NixOS:masterfrom
marsam:fix-zziplib-darwin

Conversation

@marsam

@marsam marsam commented Jun 21, 2020

Copy link
Copy Markdown
Contributor
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg Bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jun 21, 2020
@marsam

marsam commented Jun 21, 2020

Copy link
Copy Markdown
Contributor Author

@GrahamcOfBorg build mpd

@ofborg ofborg Bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jun 21, 2020
@jtojnar

jtojnar commented Jun 21, 2020

Copy link
Copy Markdown
Member

Is there an upstream issue/PR?

@jtojnar jtojnar mentioned this pull request Jun 21, 2020
Merged
10 tasks
@marsam

marsam commented Jun 21, 2020

Copy link
Copy Markdown
Contributor Author

Is there an upstream issue/PR?

no yet, sorry. I'm gonna report it later

Closing it favor of #91260

@marsam marsam closed this Jun 21, 2020
@marsam
marsam deleted the fix-zziplib-darwin branch June 21, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marsam @jtojnar