Skip to content

zziplib: 0.13.69 → 0.13.71 - #85147

Merged
jtojnar merged 1 commit into
NixOS:masterfrom
jtojnar:zziplib-0.13.70
Jun 18, 2020
Merged

zziplib: 0.13.69 → 0.13.71#85147
jtojnar merged 1 commit into
NixOS:masterfrom
jtojnar:zziplib-0.13.70

Conversation

@jtojnar

@jtojnar jtojnar commented Apr 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Member
Motivation for this change

Another step in getting rid of Python 2 (continued from #76488)

https://github.com/gdraheim/zziplib/releases/tag/v0.13.70
https://github.com/gdraheim/zziplib/releases/tag/v0.13.71

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg Bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Apr 13, 2020
@jtojnar jtojnar mentioned this pull request Apr 13, 2020
Merged
@jtojnar
jtojnar force-pushed the zziplib-0.13.70 branch 2 times, most recently from cdd727e to 31d2369 Compare April 17, 2020 20:01
@jtojnar
jtojnar marked this pull request as ready for review April 17, 2020 20:02
@jtojnar
jtojnar force-pushed the zziplib-0.13.70 branch 2 times, most recently from 2728b87 to a72cbf4 Compare April 18, 2020 17:13
@jtojnar
jtojnar marked this pull request as draft June 1, 2020 05:19
@jtojnar
jtojnar marked this pull request as ready for review June 18, 2020 10:17
@jtojnar jtojnar mentioned this pull request Jun 18, 2020
Merged
17 tasks
@jtojnar

jtojnar commented Jun 18, 2020

Copy link
Copy Markdown
Member Author

Tests were not working before and I would rather get rid of Python 2 sooner.

@jtojnar
jtojnar merged commit c334340 into NixOS:master Jun 18, 2020
@jtojnar
jtojnar deleted the zziplib-0.13.70 branch June 18, 2020 10:21
@jtojnar jtojnar changed the title zziplib: 0.13.69 → 0.13.70 zziplib: 0.13.69 → 0.13.71 Jun 18, 2020
@veprbl veprbl mentioned this pull request Jun 21, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jtojnar