Skip to content

build(deps): manage package versions centrally and finish the 10.0.10 bump #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nxships merged 1 commit into from
Aug 3, 2026
Merged

build(deps): manage package versions centrally and finish the 10.0.10 bump #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project>
<Project>

<PropertyGroup>
<Authors>nxships</Authors>
Expand All @@ -22,7 +22,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="MinVer" Version="6.0.0" PrivateAssets="all" />
<PackageReference Include="MinVer" PrivateAssets="all" />
</ItemGroup>

<ItemGroup Condition="Exists('$(MSBuildThisFileDirectory)README.md')">
Expand Down
23 changes: 23 additions & 0 deletions Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<Project>

<!-- Chain to a Directory.Build.targets sitting above this clone, if any.
MSBuild auto-imports only the nearest file, so adding one here would
otherwise silently switch off the local multi-repo workspace's
PackageReference→ProjectReference swap for every project in this repo. -->
<PropertyGroup>
<ParentDirectoryBuildTargets>$([MSBuild]::GetPathOfFileAbove('Directory.Build.targets', '$(MSBuildThisFileDirectory)..'))</ParentDirectoryBuildTargets>
</PropertyGroup>
<Import Project="$(ParentDirectoryBuildTargets)" Condition="'$(ParentDirectoryBuildTargets)' != ''" />

<!-- Dalamud.NET.Sdk hardcodes versions on the PackageReferences it injects
(Sdk.props), which central package management rejects with NU1008. We do
not own those references, so strip the metadata here and let
Directory.Packages.props carry the versions like every other package.
This has to live in .targets: Sdk.props is evaluated before
Directory.Build.props, so the items do not exist yet at that point. -->
<ItemGroup Condition="'$(ManagePackageVersionsCentrally)' == 'true'">
<PackageReference Update="DotNet.ReproducibleBuilds" Version="" />
<PackageReference Update="DalamudPackager" Version="" />
</ItemGroup>

</Project>
51 changes: 51 additions & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
<Project>

<!-- Central Package Management: every NuGet version for this repo lives here,
and the csprojs carry bare <PackageReference Include="..."/> only.

This exists to keep Dependabot's grouped bumps atomic. Dependabot scopes
NuGet updates per project directory, so with per-csproj versions a group
update could rewrite some projects and miss others — one project keeping
Microsoft.Extensions.* on the old version while another moved is enough
to fail the build with NU1605 (package downgrade, escalated to an error
by TreatWarningsAsErrors). One file means a version can only move
everywhere at once. -->

<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>

<ItemGroup>
<!-- Keep these on one version. EF Core (via NexusKit.Persistence) pulls
specific Microsoft.Extensions.* versions transitively, so a split
between the two families is exactly what produces NU1605. -->
<PackageVersion Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.10" />
<PackageVersion Include="Microsoft.Extensions.Http" Version="10.0.10" />
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.10" />
</ItemGroup>

<ItemGroup>
<!-- NexusKit framework. Open-ended ranges on purpose: the local workspace
swaps these for ProjectReferences, and CI takes the newest published
package. Do not let a bump turn them into exact pins. -->
<PackageVersion Include="NexusKit.Core" Version="[0.4.0,)" />
<PackageVersion Include="NexusKit.GameData" Version="[0.4.0,)" />
<PackageVersion Include="NexusKit.Persistence" Version="[0.4.0,)" />
<PackageVersion Include="NexusKit.Ui" Version="[0.4.0,)" />
</ItemGroup>

<ItemGroup>
<PackageVersion Include="HtmlAgilityPack" Version="1.12.4" />
<PackageVersion Include="NetStone" Version="1.4.1" />
<PackageVersion Include="MinVer" Version="6.0.0" />
</ItemGroup>

<ItemGroup>
<!-- Injected by Dalamud.NET.Sdk; their versions are stripped in
Directory.Build.targets so they resolve from here instead. Keep these
in step with the SDK unless there is a reason to diverge. -->
<PackageVersion Include="DotNet.ReproducibleBuilds" Version="1.2.39" />
<PackageVersion Include="DalamudPackager" Version="15.0.0" />
</ItemGroup>

</Project>
8 changes: 4 additions & 4 deletions External/NexusKit.Modules.FfxivCollect/NexusKit.Modules.FfxivCollect.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Http" Version="10.0.9" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.9" />
<PackageReference Include="Microsoft.Extensions.Http" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="NexusKit.Core" Version="[0.4.0,)" />
<PackageReference Include="NexusKit.Persistence" Version="[0.4.0,)" />
<PackageReference Include="NexusKit.Core" />
<PackageReference Include="NexusKit.Persistence" />
</ItemGroup>

<ItemGroup>
Expand Down
10 changes: 5 additions & 5 deletions External/NexusKit.Modules.Lodestone/NexusKit.Modules.Lodestone.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="NetStone" Version="1.4.1" />
<PackageReference Include="HtmlAgilityPack" Version="1.12.4" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.9" />
<PackageReference Include="NetStone" />
<PackageReference Include="HtmlAgilityPack" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="NexusKit.Core" Version="[0.4.0,)" />
<PackageReference Include="NexusKit.Persistence" Version="[0.4.0,)" />
<PackageReference Include="NexusKit.Core" />
<PackageReference Include="NexusKit.Persistence" />
</ItemGroup>

<ItemGroup>
Expand Down
6 changes: 3 additions & 3 deletions External/NexusKit.Modules.PluginBridge/NexusKit.Modules.PluginBridge.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.9" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="NexusKit.Core" Version="[0.4.0,)" />
<PackageReference Include="NexusKit.GameData" Version="[0.4.0,)" />
<PackageReference Include="NexusKit.Core" />
<PackageReference Include="NexusKit.GameData" />
</ItemGroup>

<ItemGroup>
Expand Down
10 changes: 5 additions & 5 deletions NexusKit.Modules.ExternalData/NexusKit.Modules.ExternalData.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.9" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.9" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="NexusKit.Core" Version="[0.4.0,)" />
<PackageReference Include="NexusKit.GameData" Version="[0.4.0,)" />
<PackageReference Include="NexusKit.Persistence" Version="[0.4.0,)" />
<PackageReference Include="NexusKit.Core" />
<PackageReference Include="NexusKit.GameData" />
<PackageReference Include="NexusKit.Persistence" />
<ProjectReference Include="..\External\NexusKit.Modules.FfxivCollect\NexusKit.Modules.FfxivCollect.csproj" />
<ProjectReference Include="..\External\NexusKit.Modules.Lodestone\NexusKit.Modules.Lodestone.csproj" />
</ItemGroup>
Expand Down
10 changes: 5 additions & 5 deletions NexusKit.Modules.InternalData/NexusKit.Modules.InternalData.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.9" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.9" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="NexusKit.Core" Version="[0.4.0,)" />
<PackageReference Include="NexusKit.GameData" Version="[0.4.0,)" />
<PackageReference Include="NexusKit.Persistence" Version="[0.4.0,)" />
<PackageReference Include="NexusKit.Core" />
<PackageReference Include="NexusKit.GameData" />
<PackageReference Include="NexusKit.Persistence" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading