build(deps): manage package versions centrally and finish the 10.0.10 bump - #32
Merged
Merged
Conversation
… bump Same change as NexusKit#33, for the same reason. Dependabot scopes NuGet updates per project directory, so a grouped bump can land in some csprojs and miss others. That is what happened to the microsoft-platform group (#31): four projects moved to 10.0.10 while NexusKit.Modules.ExternalData stayed on 10.0.9, which fails the build with NU1605 once anything pulls the newer version transitively. Central package management removes the failure mode rather than patching this instance of it: every version now lives in Directory.Packages.props and the csprojs carry bare PackageReference items, so a group bump is atomic by construction. Two knock-on fixes: - Dalamud.NET.Sdk hardcodes versions on the PackageReferences it injects, which CPM rejects with NU1008. Directory.Build.targets strips that metadata - it has to be .targets, since Sdk.props is evaluated before Directory.Build.props. That file also chains to a Directory.Build.targets above the clone if one exists, so the local multi-repo workspace's PackageReference to ProjectReference swap keeps applying. - CPM with two unmapped package sources raises NU1507, and restore warnings are errors here. nuget.config now maps sources explicitly: NexusKit.* from GitHub Packages, everything else from nuget.org. The NexusKit.* references keep their open-ended [0.4.0,) ranges. Supersedes #31; Microsoft.* land on 10.0.10 across all six projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same change as NexusKit#33, for the same reason. Dependabot scopes NuGet
updates per project directory, so a grouped bump can land in some csprojs
and miss others. That is what happened to the microsoft-platform group
(#31): four projects moved to 10.0.10 while NexusKit.Modules.ExternalData
stayed on 10.0.9, which fails the build with NU1605 once anything pulls
the newer version transitively.
Central package management removes the failure mode rather than patching
this instance of it: every version now lives in Directory.Packages.props
and the csprojs carry bare PackageReference items, so a group bump is
atomic by construction.
Two knock-on fixes:
Dalamud.NET.Sdk hardcodes versions on the PackageReferences it injects,
which CPM rejects with NU1008. Directory.Build.targets strips that
metadata - it has to be .targets, since Sdk.props is evaluated before
Directory.Build.props. That file also chains to a Directory.Build.targets
above the clone if one exists, so the local multi-repo workspace's
PackageReference to ProjectReference swap keeps applying.
CPM with two unmapped package sources raises NU1507, and restore
warnings are errors here. nuget.config now maps sources explicitly:
NexusKit.* from GitHub Packages, everything else from nuget.org.
The NexusKit.* references keep their open-ended [0.4.0,) ranges.
Supersedes #31; Microsoft.* land on 10.0.10 across all six projects.