CommitView: '}' mapping goes to first hunk if not in one already#1987
Open
washtubs wants to merge 1 commit into
Open
CommitView: '}' mapping goes to first hunk if not in one already#1987washtubs wants to merge 1 commit into
washtubs wants to merge 1 commit into
Conversation
washtubs
commented
Jul 11, 2026
| ---@param options FindOptions|nil | ||
| function Ui:find_component(f, options) | ||
| return Ui._find_component(self.layout, f, options or {}) | ||
| return Ui._find_component(self.layout.children, f, options or {}) |
Author
There was a problem hiding this comment.
find_component seemed to be unused. It was not working because the layout doesn't have ipairs as _find_component expects. layout.children does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was frustrated that in the commit view, the "Goto next"
}mapping is inert if your cursor is at the top.The current behavior is that it checks if you are hovering a hunk or diff component, otherwise it does nothing. Now I made it so it searches down to the first hunk or diff component and places the cursor there.