Allow commit hunk jumping from the metadata section#1988
Open
micampe wants to merge 1 commit into
Open
Conversation
This change allows pressing } when opening a commit to jump directly to
the first hunk from the metadata section at the top. Previously the {/}
keymaps only worked when the cursor was already within the diff portion
of the commit.
Also, { jumps back to the metadata section from the first hunk.
This behavior matches how Previous/NextSection work in the status view.
Refactored the } implementation to mirror how { is defined for clarity.
Contributor
Author
|
oops, I didn't notice #1987 had already been submitted... I guess you'll just have to pick which implementation you prefer :D if that one is preferred I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows pressing } when opening a commit to jump directly to the first hunk from the metadata section at the top. Previously the {/} keymaps only worked when the cursor was already within the diff portion of the commit.
Also, { jumps back to the metadata section from the first hunk.
This behavior matches how Previous/NextSection work in the status view.
Refactored the } implementation to mirror how { is defined for clarity.