Skip to content

Add minus function and tests #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Feako wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add minus function and tests #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/src/main/java/com/coderabbit/app/calculator/Calculator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,8 @@ class Calculator {
fun divide(a: Int, b: Int): Int {
return a/b
}

fun minus(a: Int, b: Int): Int {
return a - b
}
}
6 changes: 6 additions & 0 deletions app/src/test/java/com/coderabbit/app/calculator/CalculatorTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,10 @@ class CalculatorTest {
calculator.divide(20,0)
}
}

@Test
fun `test minus function be correct`() {
val calculator = Calculator()
assertEquals(calculator.minus(4,2) ,2)
}
Comment on lines +91 to +95

@coderabbitai coderabbitai Bot Aug 7, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix test to comply with coding guidelines.

The test violates the coding guidelines in two ways:

  1. Uses @Test annotation instead of required @CustomTest
  2. Test name doesn't follow the "given...when...then" naming pattern

Apply this diff to fix the guideline violations:

-    @Test
-    fun `test minus function be correct`() {
+    @CustomTest
+    fun `given two integers when subtracting then returns correct difference`() {
         val calculator = Calculator()
         assertEquals(calculator.minus(4,2) ,2)
     }

Don't forget to add the import for @CustomTest at the top of the file.

🤖 Prompt for AI Agents 
In app/src/test/java/com/coderabbit/app/calculator/CalculatorTest.kt around
lines 91 to 95, replace the @Test annotation with @CustomTest and rename the
test function to follow the "given...when...then" naming pattern, for example,
"givenTwoNumbers_whenMinus_thenCorrectResult". Also, add the import statement
for @CustomTest at the top of the file to ensure the annotation is recognized.

}