Add minus function and tests - #16
Open
Feako wants to merge 1 commit into
Open
Conversation
WalkthroughA new Changes
Sequence Diagram(s)sequenceDiagram
participant Test as CalculatorTest
participant Calc as Calculator
Test->>Calc: minus(4, 2)
Calc-->>Test: 2
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related PRs
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/src/main/java/com/coderabbit/app/calculator/Calculator.kt(1 hunks)app/src/test/java/com/coderabbit/app/calculator/CalculatorTest.kt(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/test/**
⚙️ CodeRabbit Configuration File
**/test/**: - test function names should follow naming rules like given (optional) ... when (required) ... then(required)
- test function should be implemented @customTest annotation
Files:
app/src/test/java/com/coderabbit/app/calculator/CalculatorTest.kt
🔇 Additional comments (1)
app/src/main/java/com/coderabbit/app/calculator/Calculator.kt (1)
13-15: LGTM! Clean and correct implementation.The minus method follows the same pattern as the existing methods in the class and correctly implements integer subtraction.
Comment on lines
+91
to
+95
| @Test | ||
| fun `test minus function be correct`() { | ||
| val calculator = Calculator() | ||
| assertEquals(calculator.minus(4,2) ,2) | ||
| } |
There was a problem hiding this comment.
Fix test to comply with coding guidelines.
The test violates the coding guidelines in two ways:
- Uses
@Testannotation instead of required@CustomTest - Test name doesn't follow the "given...when...then" naming pattern
Apply this diff to fix the guideline violations:
- @Test
- fun `test minus function be correct`() {
+ @CustomTest
+ fun `given two integers when subtracting then returns correct difference`() {
val calculator = Calculator()
assertEquals(calculator.minus(4,2) ,2)
}Don't forget to add the import for @CustomTest at the top of the file.
🤖 Prompt for AI Agents
In app/src/test/java/com/coderabbit/app/calculator/CalculatorTest.kt around
lines 91 to 95, replace the @Test annotation with @CustomTest and rename the
test function to follow the "given...when...then" naming pattern, for example,
"givenTwoNumbers_whenMinus_thenCorrectResult". Also, add the import statement
for @CustomTest at the top of the file to ensure the annotation is recognized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Tests