Repository navigation
ci: run macOS jobs only on tags and dispatch - #18
Merged
Merged
Conversation
NaNIsaac
added a commit
that referenced
this pull request
Nov 16, 2026
Strips OSC sequences terminated by either BEL (ESC ] ... BEL) or ST (ESC ] ... ESC \\) in sed before tr -d '\r\007' removes BEL. Previously tr removed \007 first, leaving fish 4.2.1 OSC 0/133 sequences intact and concatenated onto hanfix-ok. Proof that main fails the same way: - main (409229b) last passed ubuntu CI on 2026-11-04 (run 41934995726) before ubuntu-latest upgraded to fish 4.2.1-3.2; main's ci.yml has no workflow_dispatch trigger. - PR #18 leaves tests/shells.sh identical to main (409229b) and fails in test (ubuntu-latest) on fish 4.2.1 OSC output (...hanfixhanfix-ok): https://github.com/NaNIsaac/hanfix/actions/runs/43790512300/job/133047651619 Tests run: - verified sed + tr stripping against fish 4.2.1 OSC 0/133 BEL and ST sample in sh - running GitHub Actions ci on this PR Part of: CI-MACOS-RELEASE-ONLY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs macOS jobs in ci.yml and publish.yml wheels only on v* tags and workflow_dispatch, keeps Linux and Windows on pull_request and branch push, and restricts publish.yml concurrency cancellation to pull requests while adding concurrency to ci.yml.
Tests run:
Part of: CI-MACOS-RELEASE-ONLY