Skip to content

test: strip OSC sequences before removing BEL in shells.sh - #19

Merged
NaNIsaac merged 1 commit into
mainfrom
fix/shells-osc
Nov 16, 2026
Merged

NaNIsaac merged 1 commit into
mainfrom
fix/shells-osc

Conversation

@NaNIsaac

@NaNIsaac NaNIsaac commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Strips OSC sequences terminated by either BEL (ESC ] ... BEL) or ST (ESC ] ... ESC \) in sed before tr -d '\r\007' removes BEL. Previously tr removed \007 first, leaving fish 4.2.1 OSC 0/133 sequences intact and concatenated onto hanfix-ok.

Proof that main fails the same way:

Tests run:

  • verified sed + tr stripping against fish 4.2.1 OSC 0/133 BEL and ST sample in sh
  • running GitHub Actions ci on this PR

Part of: CI-MACOS-RELEASE-ONLY

@NaNIsaac
NaNIsaac merged commit 4aa3271 into main Nov 16, 2026
10 checks passed
@NaNIsaac
NaNIsaac deleted the fix/shells-osc branch November 16, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant