-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[None][chore] BREAKING: Test KV cache manager v2 as the default #17495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
yizhang-nv
wants to merge
16
commits into
NVIDIA:main
Choose a base branch
from
yizhang-nv:codex/kvcm-v2-default-true-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+148
−207
Draft
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
42daa87
[None][feat] Default to KVCM V2 and Python transceiver
yizhang-nv 2da184a
[None][test] Skip known KVCM V2 failures
yizhang-nv 64bb58c
[None][test] Skip latest KVCM V2 failures
yizhang-nv a5fb9b2
[None][test] Skip concurrent KVCM V2 OOM
yizhang-nv 3db41cb
[None][test] Re-enable fixed and rerunnable KVCM V2 tests
yizhang-nv ca1d4fc
test: remove redundant V1 disaggregation coverage
yizhang-nv d3929e4
[None][fix] Use default KV cache manager for aggregated DeepSeek V3.2
yizhang-nv 7caf188
[None][test] Pin v1 disagg metrics and update disagg coverage notes
yizhang-nv fef8957
[None][chore] Remove local disagg review documents
yizhang-nv 3abf01a
[None][test] Waive single-GPU failures pending KVCM V2 fixes
yizhang-nv 74da14b
[None][test] Remove stale V1 perf overrides and redundant test
yizhang-nv 172bc6b
[None][test] Re-enable Qwen3 LoRA after merged V2 test fix
yizhang-nv 3a18425
[None][test] Re-enable dynamic draft after merged warmup fix
yizhang-nv 5905384
[None][test] Update KVCM V2 CI coverage and waivers
yizhang-nv 11d06ea
[None][test] Unwaive KVCM V2 cases except initialization OOM
yizhang-nv a27e923
[None][test] Initialize max beam width in KV cache budget fixture
yizhang-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
examples/disaggregated/slurm/simple_example/gen_extra-llm-api-config.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| cache_transceiver_config: | ||
| backend: UCX | ||
| transceiver_runtime: CPP | ||
| backend: NIXL | ||
| max_tokens_in_buffer: 2048 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 0 additions & 20 deletions
20
...ion/defs/disaggregated/test_configs/disagg_config_ctxtp1_gentp1_deepseek_v3_lite_ucx.yaml
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 0 additions & 19 deletions
19
...ion/defs/disaggregated/test_configs/disagg_config_ctxtp2_gentp2_deepseek_v3_lite_mpi.yaml
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When --transceiver_runtime CPP is selected, should the generated configuration also set kv_cache_config.use_kv_cache_manager_v2: false? The script currently omits this field, and this PR changes its default from auto to True, bypassing the previous V1 fallback for CPP and pairing the C++ transceiver with a V2 manager. Is there another compatibility path that handles this?