[None][chore] BREAKING: Test KV cache manager v2 as the default - #17495
yizhang-nv wants to merge 16 commits into
Conversation
|
/bot run --disable-fail-fast |
|
PR_Github #65256 [ run ] triggered by Bot. Commit: |
|
PR_Github #65256 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
8a8cd95 to
e289dd8
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #66215 [ run ] triggered by Bot. Commit: |
|
PR_Github #66215 [ run ] completed with state
|
|
/bot run --disable-fail-fast --disable-reuse-test --stage-list "A10-PyTorch-1, A10-PyTorch-2, A10-PyTorch-3, A30-AutoDeploy-1, CPU-Generic-arm-1, CPU-Generic-x86-1, DGX_B200-AutoDeploy-1, DGX_B200-PyTorch-1, DGX_B200-PyTorch-2, DGX_B200-PyTorch-3, DGX_B200-PyTorch-4, DGX_B200-PyTorch-5, DGX_B200-PyTorch-6, DGX_B200-PyTorch-7, DGX_B200-PyTorch-8, DGX_B200-PyTorch-9, DGX_H100-PyTorch-1, DGX_H100-PyTorch-2, DGX_H100-PyTorch-3, DGX_H100-PyTorch-4, DGX_H100-PyTorch-5, DGX_H100-PyTorch-6, H100_PCIe-AutoDeploy-1, H100_PCIe-PyTorch-Ray-1, DGX_B200-PyTorch-Post-Merge-1, DGX_B200-PyTorch-Post-Merge-2, DGX_H100-PyTorch-Post-Merge-1, DGX_H100-PyTorch-Post-Merge-2" |
|
PR_Github #66680 [ run ] triggered by Bot. Commit: |
|
PR_Github #66680 [ run ] completed with state
|
6e62635 to
39ed067
Compare
|
/bot run --disable-fail-fast --disable-reuse-test --extra-stage "Post-Merge" |
|
PR_Github #66784 [ ] completed with state |
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot run --post-merge --disable-fail-fast --disable-reuse-test |
|
PR_Github #66943 [ run ] triggered by Bot. Commit: |
|
PR_Github #66943 [ run ] completed with state
|
39ed067 to
9c5c909
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #67082 [ run ] triggered by Bot. Commit: |
|
PR_Github #67082 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
| echo " --tp_size N Tensor parallel size (default: 1)" | ||
| echo " --transceiver_backend UCX|NIXL Cache-transceiver backend (default: NIXL)" | ||
| echo " --transceiver_runtime CPP|PYTHON Cache transceiver runtime (default: CPP)" | ||
| echo " --transceiver_runtime CPP|PYTHON Cache transceiver runtime (default: PYTHON)" |
There was a problem hiding this comment.
When --transceiver_runtime CPP is selected, should the generated configuration also set kv_cache_config.use_kv_cache_manager_v2: false? The script currently omits this field, and this PR changes its default from auto to True, bypassing the previous V1 fallback for CPP and pairing the C++ transceiver with a V2 manager. Is there another compatibility path that handles this?
|
PR_Github #74021 [ run ] completed with state
|
3be5469 to
b0f1682
Compare
b0f1682 to
f518b8b
Compare
|
/bot run --post-merge --disable-multi-gpu-test --disable-fail-fast |
|
PR_Github #74372 [ run ] triggered by Bot. Commit: |
|
PR_Github #74372 [ run ] completed with state
|
f518b8b to
afbe888
Compare
Enable KV cache manager V2 and the Python cache transceiver by default, and migrate supported examples and tests to the V2 path. Keep explicit V1 and C++ settings only for legacy transport, compatibility, and dedicated coverage. Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
afbe888 to
a27e923
Compare
|
/bot run --post-merge --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #75481 [ run ] triggered by Bot. Commit: |
|
PR_Github #75481 [ run ] completed with state
|
@coderabbitai summary
Description
This draft PR changes
KvCacheConfig.use_kv_cache_manager_v2from the"auto"default toTrueand updates the corresponding declaration test.The purpose is to run the full pre-merge CI suite and identify failures or compatibility gaps that are currently avoided by the automatic fallback logic. This is an experimental PR and is not intended for merge until the CI fallout has been reviewed.
Test Coverage
python3 scripts/generate_llm_args_golden_manifest.pypassed; the manifest did not change because it does not record field defaults.pytest -s tests/unittest/llmapi/test_llm_args.py: 278 passed, 8 failed. Seven failures are direct fallout from bypassing the"auto"fallback: the no-preference fallback, three incompatible disaggregated-serving cases, two DEFAULT-backend environment routes, and the no-checkpoint-loader path. The remainingtest_runtime_sizesfailure came from the container's unrelated Triton API mismatch (triton_kernels.tensor.bitwidth).PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.