Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
3e3f907 to
9caaf25
Compare
aaa901f to
45a097e
Compare
9caaf25 to
893e2d2
Compare
45a097e to
4d9636e
Compare
893e2d2 to
f679ce1
Compare
4d9636e to
022b7e1
Compare
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
022b7e1 to
c39fa9a
Compare
|
Coordination with #4011: that PR has been approved and submitted to the merge queue. I compared the server patches: both fix replay after the previous supervisor registration was removed and suppress duplicate relay delivery to the same session. #4011 strengthens the implementation with queue-capacity reservation, current-session revalidation, atomic delivery bookkeeping/enqueueing, and a shared absolute setup deadline. Recommended follow-up after #4011 merges: rebase this draft onto main, remove the overlapping supervisor_session.rs production fix, and retain/adapt the deterministic startup/reconnect conformance scenarios, Docker/Podman disconnect-injection fixtures, and architecture documentation. Those tests remain valuable coverage beyond #4011's registry and subprocess regressions. #4011 also fixes SSH proxy shutdown/error propagation and oversized Docker gRPC diagnostics; it does not resolve the underlying Docker startup stall. |
Summary
Add deterministic conformance coverage for relay attachment recovery across supervisor-session startup and reconnect windows. Carry the focused server fix in this draft so the regression scenario demonstrates both the failure and the intended recovery behavior.
Stack
Main stack: #3641 → #3597 → #3637.
This draft is a side branch from #3597 and should remain draft until the relay fix is accepted independently of the file-transfer migration.
Related Issue
No issue required: this is a localized regression test and fix for the intermittent relay loss originally investigated in #3583 and #3588.
Failure evidence
Changes
Testing
mise run pre-commitrelay open timed outbefore the fixrelay open timed outbefore the fixrelay open timed outbefore the fixChecklist