Skip to content

fix(server): avoid duplicate relay opens on reconnect - #3619

Closed
drew wants to merge 1 commit into
codex/stability-shortlist-relay-basefrom
codex/stability-shortlist-relay-dedupe
Closed

drew wants to merge 1 commit into
codex/stability-shortlist-relay-basefrom
codex/stability-shortlist-relay-dedupe

Conversation

@drew

@drew drew commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

Avoid sending a queued relay open twice during supervisor session setup while preserving replay to a replacement session. Clean restack of #3588 on the preceding relay fix.

Related Issue

No issue required: localized correctness follow-up to #3583.

Changes

  • Track the session most recently sent each pending relay open.
  • Skip duplicate delivery to that same session and add a regression test.
  • Document the per-session delivery invariant.

Testing

Checklist

  • Conventional, signed-off commit.
  • Architecture documentation updated.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@drew drew added the automated-flake-find PRs produced by the automated E2E flake-finding campaign label Sep 23, 2026
@copy-pr-bot

copy-pr-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@elezar

elezar commented Oct 1, 2026

Copy link
Copy Markdown
Member

Cross-reference: #4011 has been approved and submitted to the merge queue. It addresses the same per-session duplicate relay delivery fixed in #3588 and restacked here, and strengthens the implementation by reserving queue capacity and atomically validating the session, recording delivery, and enqueueing the relay open.

Draft #3766 also carries this server fix plus deterministic reconnect conformance coverage. After #4011 merges, rebase #3766 and remove its overlapping server patch while retaining its tests and architecture documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-flake-find PRs produced by the automated E2E flake-finding campaign

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants