Skip to content

fix: hunter doesn't work with MSVC 2026#648

Open
shaosu-nvidia wants to merge 5 commits into
mainfrom
ssx/fix_hunter_version
Open

fix: hunter doesn't work with MSVC 2026#648
shaosu-nvidia wants to merge 5 commits into
mainfrom
ssx/fix_hunter_version

Conversation

@shaosu-nvidia

@shaosu-nvidia shaosu-nvidia commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated build system dependencies to improve compatibility with newer Visual Studio toolsets on Windows CI environments.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 81214805-4af2-4d66-9d8e-b0a066a10823

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR updates the HunterGate CMake dependency configuration in a single file. The change replaces a commit-pinned tarball with the v0.26.9 release tarball and corresponding SHA1 hash. Two inline comments are added: one describing the MSVC_VERSION-to-Visual Studio version mapping logic, and another explaining why the version bump was necessary to avoid "Unexpected MSVC_VERSION" errors when the Windows CI runner uses the VS 2026 toolset. The underlying download logic and subsequent CMake includes remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the main change: updating HunterGate to v0.26.9 to fix compatibility with MSVC 2026, which directly addresses the primary objective of the PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ssx/fix_hunter_version

Comment @coderabbitai help to get the list of available commands and usage tips.

@shaosu-nvidia shaosu-nvidia force-pushed the ssx/fix_hunter_version branch from 5e63226 to c97a2da Compare June 8, 2026 23:38
@aristarkhovNV

Copy link
Copy Markdown
Collaborator

might as well unpun the windows runner image since it apparently does not pin the VS version properly

@shaosu-nvidia

Copy link
Copy Markdown
Contributor Author

Seems it's still failing. Maybe the hunter is not compatible at all with the VS 2026

@shaosu-nvidia shaosu-nvidia changed the title Use the most recent hunter fix: hunter doesn't work with MSVC 2026 Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants