fix: hunter doesn't work with MSVC 2026#648
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR updates the HunterGate CMake dependency configuration in a single file. The change replaces a commit-pinned tarball with the v0.26.9 release tarball and corresponding SHA1 hash. Two inline comments are added: one describing the MSVC_VERSION-to-Visual Studio version mapping logic, and another explaining why the version bump was necessary to avoid "Unexpected MSVC_VERSION" errors when the Windows CI runner uses the VS 2026 toolset. The underlying download logic and subsequent CMake includes remain unchanged. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
5e63226 to
c97a2da
Compare
|
might as well unpun the windows runner image since it apparently does not pin the VS version properly |
|
Seems it's still failing. Maybe the hunter is not compatible at all with the VS 2026 |
Summary by CodeRabbit