webxr: use versioned client URL#617
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR refactors CloudXR web client URL references across the documentation. The Sphinx configuration now computes a branch-specific client URL from the multiversion name and injects it globally via Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Does this fix #584? |
| .. parsed-literal:: | ||
|
|
||
| https://nvidia.github.io/IsaacTeleop/client/main/?oobEnable=1&serverIP=<HOST_IP>&port=48322 | ||
| |web_client_url|\ ?oobEnable=1&serverIP=<HOST_IP>&port=48322 |
There was a problem hiding this comment.
I'm not 100% certain about this so please double check
There was a problem hiding this comment.
I think we default to https://nvidia.github.io/IsaacTeleop/client/
There was a problem hiding this comment.
What is it that you are uncertain about?
There was a problem hiding this comment.
oob does not have per release url
The OOB launcher hardcoded the WebXR client at /client/main/ (in the WiFi
bookmark, the USB-local static-asset download, the cache-clear origin, and
the --usb-local help text), while the non-OOB startup line already derived a
version-matched client URL. OOB users on a release line were pointed at the
main client instead of the one matching their install.
Add a single shared resolver in oob_teleop_env:
versioned_web_client_url(version):
- clean MAJOR.MINOR.PATCH (tag build) -> client/vMAJOR.MINOR.PATCH/
- rc/dev or other MAJOR.MINOR -> client/release-MAJOR.MINOR.x/
- unparseable -> client/ (site redirects to stable)
default_web_client_origin(): reads the installed isaacteleop distribution
version via importlib.metadata (namespace-independent) and maps it through
the resolver; falls back to /client/main/ when the version can't be resolved
(dev trees, tests).
Route every OOB client-URL site through default_web_client_origin() and the
non-OOB startup line through versioned_web_client_url(), so both agree on
which client to open. This generalizes the per-tag case on top of the
release-line mapping introduced for the non-OOB line (#585).
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
4 participants
Summary by CodeRabbit