Extend static analysis for arithmetic operators - #6476
Open
rostan-t wants to merge 6 commits into
Open
Conversation
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Collaborator
Author
|
!build |
Contributor
Collaborator
|
CI MESSAGE: [66962570]: BUILD STARTED |
18 tasks
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
rostan-t
force-pushed
the
ndd-arithm-ops-static-analysis
branch
from
September 9, 2026 13:11
94b76d7 to
e28c90a
Compare
Collaborator
Author
|
!build |
Collaborator
|
CI MESSAGE: [66975775]: BUILD STARTED |
Collaborator
|
CI MESSAGE: [66975775]: BUILD PASSED |
Collaborator
|
CI MESSAGE: [66962570]: BUILD PASSED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Description:
This extends dynamic mode static analysis to support arithmetic operators.
PR #6475 promotes bools, ints, and floats to constants in arithmetic ops. With this PR, we can limit it to only those that are provably constant.
To prevent a regression on Python 3.10 when a call is on the same line as an arithmetic operation, we also add disambiguation on the bytecode since exact span checking is absent.
Additional information:
Affected modules and functionalities:
Dynamic mode.
Key points relevant for the review:
Commits a677329 and 0374268 belong to #6475.
Tests:
test_arithm_ops.pyChecklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A