Repository navigation
Add dynamic letterbox crop detection - #1579
Merged
RadicalMuffinMan merged 8 commits intoOct 6, 2026
Merged
Conversation
Contributor
Author
|
@mattsigal This follows up on the dynamic re-scan idea discussed on #1524. It adds configurable re-cropping and includes the fullscreen/windowed zoom and subtitle-placement fixes needed to make crop mode usable. Interested in your thoughts, especially on the crop/zoom interaction. |
github-actions
Bot
added
the
Missing Template
Contributor
Author
|
More specifically on subtitles: on desktop libmpv, native bottom-aligned subtitles can still use the original uncropped frame coordinates. After the lower letterbox bar is removed, that can place them outside the retained picture. This PR remaps the subtitle position into the accepted crop rectangle while crop mode is active, then restores the exact previous position when it is cleared. |
github-actions
Bot
added
Android
Android TV
Bug
selmant
marked this pull request as draft
September 17, 2026 19:35
selmant
marked this pull request as ready for review
September 17, 2026 19:38
✅ Build SuccessfulAll platform builds and tests passed. You can download the test artifacts below. Tests ✅ 4008 passed, analyzer clean
|
selmant
marked this pull request as draft
September 19, 2026 20:18
selmant
marked this pull request as ready for review
September 24, 2026 22:18
Contributor
Author
|
Optimized the scan so it no longer restarts hardware decode. The every-second check downloads a few frames with After the crop is applied, the picture fills the source-sized frame. Fit was painting the removed bars back into that frame, which made a 16:9 screen look unchanged. The debug scan logs are gone. |
A short hwdownload runs cropdetect on VAAPI, Vulkan, D3D11, VideoToolbox, and nvdec, then leaves the decoder alone. Copy-back is only the fallback, and a wider display keeps the cropped picture in fit instead of covering it again.
A wider crop now sets panscan so the bars are not painted back into the source-sized frame, and the player no longer prints the letterbox scan trace.
selmant
force-pushed
the
feat/dynamic-letterbox-crop
branch
from
September 24, 2026 22:21
f446fc9 to
e5ed717
Compare
A centred picture with bars on every side is now cropped, confirmed over later reads in one-shot mode so a title card is not. Known ratios read the crop's own shape, seeks account for playback speed, Media3 keeps scanning through long pauses and retries a scan whose captures all failed, mpv serializes crop apply and clear, stops caching panscan and hands it to the Android TV surface, one-shot frame sampling waits out a pending crop, and the zoom mode is honoured when nothing is cropped. Unreachable screenshot-window code and unused constants are gone. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
10 of 14 tasks
…op so the cropped picture fits any window and only covers in fullscreen, pace Media3 rescans by capture time, scope the libswscale error filter to a frame sample, and drop the format-only reflows and the panscan workaround
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (59)
📒 Files selected for processing (22)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Adds configurable dynamic re-cropping to the encoded-black-bar cropper introduced in #1524. This includes the presentation and subtitle fixes required for crop mode to work correctly across fullscreen and windowed playback.
Related Issues
Type of Change
Changes Made
Platform
Testing
Test Steps
Screenshots (if applicable)
Not applicable; this changes playback behavior without adding a new UI surface.
Checklist