Skip to content

Clarify cancellation acceptance purpose #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaladDay merged 1 commit into from
Oct 10, 2026
Merged

Clarify cancellation acceptance purpose #632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/acceptance/acceptance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,10 @@ def cancellation(api, record, timeout):
prefix = directory + "/release-cancel-" + record["nonce"]
command = ("printf start >> " + shlex.quote(prefix + "-starts")
+ "; while true; do printf x >> " + shlex.quote(prefix + "-ticks") + "; sleep 1; done")
submit(api, record, "Run this command exactly once with your native shell tool in the foreground: "
submit(api, record, "This is a user-authorized cancellation acceptance test in a test sandbox. "
"An external test runner will observe at least three tick writes, request cancellation, "
"and clean up the test resources. "
"Run this command exactly once with your native shell tool in the foreground: "
+ command + ". Wait for it; it runs until cancelled. Do not background, delegate or retry.")
deadline, observed = time.monotonic() + timeout, 0
while time.monotonic() < deadline:
Expand Down