Require explicit service Harness qualification declarations - #259
Merged
Merged
Conversation
SaladDay
marked this pull request as ready for review
September 30, 2026 07:40
SaladDay
force-pushed
the
codex/explicit-service-harness-profiles
branch
3 times, most recently
from
September 30, 2026 08:10
61adb96 to
c9520ff
Compare
SaladDay
force-pushed
the
codex/explicit-service-harness-profiles
branch
from
September 30, 2026 08:24
c9520ff to
a5c0b69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service Harness profiles could omit capability flags or validation callbacks and still authorize admission. Require explicit support decisions and common-only or additional validation policies at catalog construction, rejecting missing, invalid and contradictory declarations before use.
Keep Runtime availability separate from service qualification, preserve Codex/Claude/MiniMax admission behavior and error precedence, and retain zero-value versus explicitly empty catalog semantics. Definition and validation stay in
services/core/internal/engine/profile.go. Update the authoritative Harness guide and contributor owner index; do not restore the removed docs site. This changes no public API, model protocol, native adapter or deployment.Final head:
a5c0b69feed4eb87445c08b86bbbc47b220181ca, baseline015d9f943446383c61e2163faf593f07a5a723e5.Validation:
c9520ffe. Every changed Go file is byte-for-byte identical in the final head. Coverage includes missing fields, invalid values, policy/callback mismatches, placement/MCP combinations, immutable catalogs, admission precedence, message images and structured-output dispatch.c9520ffealso passed full make check, official-client acceptance and all native platforms. This is reusable code evidence, not a claim that final-head CI has completed.Per the latest task instruction, targeted checks and necessary cross-module/database validation qualify this subtask; no additional duplicate full run is requested. The coordinating test chat owns final acceptance and merge, including required branch checks. These fixtures are not new live model qualification. No release, deployment or existing data changes.