Skip to content

fix(testing): point ab-testing at the fixture method that exists #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MajorLift wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(testing): point ab-testing at the fixture method that exists #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions domains/testing/skills/ab-testing/repos/metamask-extension.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ const activeABTests = experiment.isActive
- Register every new remote A/B test flag in
`test/e2e/feature-flags/feature-flag-registry.ts` with the production
default threshold-array JSON value.
- Use test overrides such as `manifestFlags.remoteFeatureFlags` or
`FixtureBuilder.withRemoteFeatureFlags(...)` when a test needs
deterministic assignment.
- Use test overrides such as `manifestFlags.remoteFeatureFlags`, or
`withRemoteFeatureFlagController({ remoteFeatureFlags: { ... } })` on
`FixtureBuilderV2`, when a test needs deterministic assignment.
- If the change is copy-only or config-only, you may skip new tests with a brief rationale.
7. Run the A/B compliance checker using the repository's current supported
invocation and report the result.
Expand Down