Conversation
`FixtureBuilder.withRemoteFeatureFlags(...)` does not exist in `metamask-extension`. Specs call `withRemoteFeatureFlagController` on `FixtureBuilderV2`, with the flags nested under `remoteFeatureFlags`, so the argument shape changes along with the name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
ab-testingextension overlay tells an agent writing a flag-gated test to callFixtureBuilder.withRemoteFeatureFlags(...). That method does not exist inmetamask-extension, so a test written from the overlay fails before it runs.Overview
Replaces it with the method specs actually use,
withRemoteFeatureFlagControlleronFixtureBuilderV2, with its real argument shape. The flags nest underremoteFeatureFlags, which renaming the method alone would have left out.The other override in the same sentence,
manifestFlags.remoteFeatureFlags, is correct and unchanged.Showcase
Read at
metamask-extension0269fae:class FixtureBuilderV2is declared atfixture-builder-v2.ts:178, andwithRemoteFeatureFlagController(data: Partial<RemoteFeatureFlagControllerState>)atfixture-builder-v2.ts:428.remoteFeatureFlags, for examplemoney-account-vault-restore.spec.ts:120..tsfile outsidetest/e2e/feature-flags/feature-flag-registry.tsdefines or callswithRemoteFeatureFlags(. The same search forwithRemoteFeatureFlagController(returns 8 matching lines, so the search shape finds the method that does exist.The overlay's wording matches two doc comments in that registry, at line 17 and line 3561, which is the likely origin. Those comments live in
metamask-extensionand are not changed here.