Fix CDATA decoding in XML text content - #369
Merged
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This was referenced Sep 20, 2026
Owner
|
@developer0hye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve CDATA content when reading XML text with
Reader::read_text_into. The shared decoder now copies CDATA sections literally and unescapes only the surrounding text, preventing valid header/footer ampersands from panicking and avoiding literal CDATA delimiters in the parsed value.Related: #368
Related: developer0hye/office2pdf#1709
Regression coverage
A synthetic workbook exercises both headers and footers through the public XLSX reader: ordinary entities, literal ampersands and tags, mixed text/CDATA, numeric references, adjacent/empty sections, and escaped text that resembles a CDATA delimiter. The test panics on unchanged master and passes with the patch.
Validation
cargo test --locked --test cdata_text: passed.cargo test --locked: full suite passed, including documentation tests.cargo clippy --locked -- -D warnings: passed.git diff --check: passed.The local generated lockfile is retained for repeatability and not committed, following the repository's library policy. No dependencies or binary fixtures are added. This is an AI-assisted implementation.