Repository navigation
Fix CDATA decoding in worksheet text - #13
Merged
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
13 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port MathNya#369 to the parser-safety branch used by office2pdf. Copy CDATA content literally and decode entity references only outside it, so worksheet headers and footers no longer retain CDATA delimiters.
Retain the fork's existing tolerant handling of malformed text, with a regression for malformed references and unterminated CDATA. Public XLSX reader tests cover ordinary entities, literal CDATA ampersands, mixed text, adjacent/empty sections, and escaped delimiter-looking text in both headers and footers.
Related: developer0hye/office2pdf#1709
Validation:
cargo test --locked: 53 unit, 1 CDATA regression, and 97 integration tests passed.cargo clippy --locked -- -D warnings: passed.git diff --check: passed.The workflow branch patterns now include slash-named branches so this fork PR and its target run CI. Current-head PR CI passed (35518268005); the redundant push run was intentionally canceled.