Skip to content

test(cost): OpenAI fixture keys read as obvious fakes - #2579

Merged
Makisuo merged 1 commit into
mainfrom
t3/remove-committed-secrets
Nov 14, 2026
Merged

test(cost): OpenAI fixture keys read as obvious fakes#2579
Makisuo merged 1 commit into
mainfrom
t3/remove-committed-secrets

test(cost): OpenAI fixture keys read as obvious fakes

30af059
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 14, 2026 in 19s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. Fixture-only edit: the new placeholder still matches couldBeKey's shape check and every assertion compares against the constant.
no findings · tests not needed · risk low

Replaces the OpenAI admin-key fixtures in two cost tests with obvious fakes so secret scanning stops flagging them. The placeholders still satisfy the key-shape check and every assertion compares against the constant, so the tests are unaffected.

  • KEY/OTHER_KEY in OpenAiCostConnectionService.test.ts and KEY in OpenAiCostProvider.test.ts are now fake-looking placeholders
What was checked
  • couldBeKey in OpenAiCostConnectionService.ts:43 accepts the new value: printable, no space, under the max length
  • Assertions use the constants (Bearer ${KEY}, ciphertext difference), so no literal key string is pinned
  • fake-openai.ts:133 only records the Authorization header, it does not compare it to a fixed key

30af059 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

View more details on Maple Review Bot