Repository navigation
test(cost): OpenAI fixture keys read as obvious fakes - #2579
Conversation
Secret scanning flagged the sk-admin- test keys as real OpenAI keys. They now say FAKE-TEST-KEY so neither a scanner nor a reader mistakes them.
Maple review🟢 Confidence 10/10 · safe to merge. Fixture-only edit: the new placeholder still matches Replaces the OpenAI admin-key fixtures in two cost tests with obvious fakes so secret scanning stops flagging them. The placeholders still satisfy the key-shape check and every assertion compares against the constant, so the tests are unaffected.
|
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Secret scanning flagged the
sk-admin-keys in two OpenAI cost tests as real OpenAI API keys. They were placeholders, so nothing needs rotating. They now readsk-admin-FAKE-TEST-KEY-not-a-real-secret, which still passes the key-shape check.The two open alerts point at the old commit, so they still have to be closed by hand as "Used in tests".
OpenAiCostConnectionService.test.tsandOpenAiCostProvider.test.ts: 14/14 pass.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.