Skip to content

test(cost): OpenAI fixture keys read as obvious fakes - #2579

Merged
Makisuo merged 1 commit into
mainfrom
t3/remove-committed-secrets
Nov 14, 2026
Merged

Makisuo merged 1 commit into
mainfrom
t3/remove-committed-secrets

Conversation

@Makisuo

@Makisuo Makisuo commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Secret scanning flagged the sk-admin- keys in two OpenAI cost tests as real OpenAI API keys. They were placeholders, so nothing needs rotating. They now read sk-admin-FAKE-TEST-KEY-not-a-real-secret, which still passes the key-shape check.

The two open alerts point at the old commit, so they still have to be closed by hand as "Used in tests".

OpenAiCostConnectionService.test.ts and OpenAiCostProvider.test.ts: 14/14 pass.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Devin Review

Secret scanning flagged the sk-admin- test keys as real OpenAI keys. They now
say FAKE-TEST-KEY so neither a scanner nor a reader mistakes them.
@maple-review-bot

maple-review-bot Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 10/10 · safe to merge. Fixture-only edit: the new placeholder still matches couldBeKey's shape check and every assertion compares against the constant.
no findings · tests not needed · risk low

Replaces the OpenAI admin-key fixtures in two cost tests with obvious fakes so secret scanning stops flagging them. The placeholders still satisfy the key-shape check and every assertion compares against the constant, so the tests are unaffected.

  • KEY/OTHER_KEY in OpenAiCostConnectionService.test.ts and KEY in OpenAiCostProvider.test.ts are now fake-looking placeholders

30af059 · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Makisuo
Makisuo merged commit 4ed0d73 into main Nov 14, 2026
32 of 33 checks passed
@Makisuo
Makisuo deleted the t3/remove-committed-secrets branch November 14, 2026 00:14

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant