Skip to content

fix(status-pages): import escapeHtml from @maple/strings in markdown.ts - #2468

Merged
JeremyFunk merged 1 commit into
mainfrom
fix/status-page-markdown-escape-import
Nov 10, 2026
Merged

JeremyFunk merged 1 commit into
mainfrom
fix/status-page-markdown-escape-import

Conversation

@JeremyFunk

@JeremyFunk JeremyFunk commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

#2447 moved escapeHtml out of ./escape while #2430 added markdown.ts importing it from there, breaking the web build, typecheck and editor tests on main.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

#2447 moved escapeHtml out of ./escape while #2430 added markdown.ts importing it from there, breaking the web build, typecheck and editor tests on main.
@maple-review-bot

maple-review-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 10/10 · safe to merge. Import-only fix; escapeHtml resolves from @maple/strings, a declared dependency that escape.ts already imports from.
no findings · tests covered · risk low

Restores main's status-page build by importing escapeHtml from @maple/strings, where #1438 moved it, instead of the now-deleted re-export in ./escape. Safe to merge.

  • markdown.ts imports escapeHtml from @maple/strings; ./escape keeps safeUrl

4893b3f · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@JeremyFunk
JeremyFunk merged commit 4f60edb into main Nov 10, 2026
26 of 27 checks passed
@JeremyFunk
JeremyFunk deleted the fix/status-page-markdown-escape-import branch November 10, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant