Repository navigation
fix(chat-platform): keep the page block's comment vendor-neutral - #2464
Conversation
This comment has been minimized.
This comment has been minimized.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
vendor-isolation.test.ts scans this package for chat vendor names, comments included, and the comment added in #2454 named one.
This comment has been minimized.
This comment has been minimized.
…e-import # Conflicts: # packages/status-page/src/markdown.ts
Maple review🟢 Confidence 10/10 · safe to merge. Two-line comment reword with no code change; the vendor-isolation scan's name list no longer matches the text at Rewords the
|
The
escapeHtmlimport this PR also fixed has landed separately in #2468. What is left is the second breakage onmain.What
packages/chat-platform/src/vendor-isolation.test.tsscans the package for chat vendor names, comments included. The comment onChatPageBlockadded in #2454 names one, so the test fails wherever the chat-platform suite runs (seen asTests (small-1)/Tests (small-3)on PRs that include main):Fix: reword the comment. No code change.
Verified
packages/chat-platform: 361 tests, including the vendor-isolation scan.Summary by CodeRabbit
ChatPageBlockis supported on platforms that render HTML pages inside messages.