Skip to content

fix(chat-platform): keep the page block's comment vendor-neutral - #2464

Merged
Makisuo merged 3 commits into
mainfrom
fix/status-page-escape-import
Nov 10, 2026
Merged

Makisuo merged 3 commits into
mainfrom
fix/status-page-escape-import

Conversation

@Makisuo

@Makisuo Makisuo commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

The escapeHtml import this PR also fixed has landed separately in #2468. What is left is the second breakage on main.

What

packages/chat-platform/src/vendor-isolation.test.ts scans the package for chat vendor names, comments included. The comment on ChatPageBlock added in #2454 names one, so the test fails wherever the chat-platform suite runs (seen as Tests (small-1) / Tests (small-3) on PRs that include main):

AssertionError: expected [ Array(1) ] to deeply equal []
+ "packages/chat-platform/src/render/blocks.ts:162: * A self-contained HTML page, for a platform that shows one inside a message (...'s HTML"

Fix: reword the comment. No code change.

Verified

  • packages/chat-platform: 361 tests, including the vendor-isolation scan.

Summary by CodeRabbit

  • Documentation
    • Clarified that ChatPageBlock is supported on platforms that render HTML pages inside messages.
    • Clarified that other platforms continue to display the standard Markdown fallback.

…wn renderer

#2447 moved escapeHtml out of escape.ts and #2430 added markdown.ts importing
it from there. Each passed alone; together main fails typecheck, lint and the
web build, which blocks the production deploy.
@maple-review-bot

This comment has been minimized.

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

ChatPageBlock documentation now describes platforms that render an HTML page inside a message without naming Hazel. The markdown fallback description remains.

Changes: ChatPageBlock documentation

Layer / File(s) Summary
Update renderer description
packages/chat-platform/src/render/blocks.ts
The comment describes platforms that render an HTML page inside a message. It retains the markdown fallback description.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Possibly related PRs

Suggested reviewers: jeremyfunk

Merge Risk: Minimal · up to 58701

The comment is now vendor-neutral, with no identified merge-blocking issue.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the vendor-neutral wording change to the page block’s comment.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3ce53548-e900-41af-a264-3d868d533374
Commits

Reviewing files that changed from the base of the PR and between 4f60edb and 58701ba.

Files selected for processing: 1

  • packages/chat-platform/src/render/blocks.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

vendor-isolation.test.ts scans this package for chat vendor names, comments
included, and the comment added in #2454 named one.
@Makisuo Makisuo changed the title fix(status-page): import escapeHtml from @maple/strings in the markdown renderer fix: get main green again (status-page import, vendor-neutral comment in chat-platform) Nov 10, 2026
@maple-review-bot

This comment has been minimized.

…e-import

# Conflicts:
#	packages/status-page/src/markdown.ts
@Makisuo Makisuo changed the title fix: get main green again (status-page import, vendor-neutral comment in chat-platform) fix(chat-platform): keep the page block's comment vendor-neutral Nov 10, 2026
@maple-review-bot

maple-review-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 10/10 · safe to merge. Two-line comment reword with no code change; the vendor-isolation scan's name list no longer matches the text at blocks.ts:162.
no findings · tests not needed · risk low

Rewords the ChatPageBlock doc comment so it no longer names a chat vendor, letting the chat-platform vendor-isolation scan pass on main. Comment-only; safe to merge.

  • ChatPageBlock doc comment no longer names a vendor, keeping the isolation scan green

58701ba · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@Makisuo
Makisuo merged commit d32370e into main Nov 10, 2026
38 checks passed
@Makisuo
Makisuo deleted the fix/status-page-escape-import branch November 10, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant