Skip to content

fix(security): keep the estimated severity inside the open leads column - #2465

Merged
Makisuo merged 1 commit into
mainfrom
fix/security-open-leads-badge
Nov 10, 2026
Merged

Makisuo merged 1 commit into
mainfrom
fix/security-open-leads-badge

Conversation

@Makisuo

@Makisuo Makisuo commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

The Security overview's Open leads list gives the severity badge a fixed w-16 column. An unverified lead rendered High · unverified, which overflowed the column and ran under the title.

Now the column shows only the estimated severity (the dashed outline already marks it as an estimate), and the row ends with the same Unverified chip the findings list uses. Other findingBadge call sites sit in wrapping rows and are unchanged.

Verification

  • tsrs --noEmit (apps/web): no errors in the touched files. The one error on main, status-page/markdown.ts escapeHtml, is fixed by fix(chat-platform): keep the page block's comment vendor-neutral #2464.
  • oxlint -c .oxlintrc.effect.json and oxfmt --check on both files: clean.
  • /lab/security (dark), screenshotted with Playwright. For the shots only, one fixture lead was given a critical estimate so an unverified lead reaches the top 5. Critical is the longest label, so it is the worst case.
Before After
before after

Wider layout:

after, wide

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Summary by CodeRabbit

  • New Features
    • Security findings now display estimated severity with a dashed badge. Unverified findings are labeled, and target lead counts appear in a more compact layout.

The overview's open leads list gives the badge a fixed w-16 column, and
"High · unverified" overflowed it under the title. The column now shows
only the estimated severity (dashed outline), and the row ends with the
same Unverified chip the findings list uses.
@maple-review-bot

maple-review-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 10/10 · safe to merge. Pure markup change inside one row; the predicate guard and both call sites line up, and recent UI-only remaps of this file shipped without test edits.
no findings · tests not needed · risk low

The Open leads row now renders only the estimated severity in its fixed 64px column and moves the "Unverified" mark to a trailing chip, matching the findings list. Contained view change, safe to merge.

  • estimatedSeverityBadge renders the estimate alone in the dashed outline badge
  • findingItem ends with unverifiedChip for unverified leads and its title column grows

869cc4f · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The security overview now displays estimated-severity badges and unverified chips for unverified findings. The existing confirmed-severity rendering remains. The severity dot and count markup is compacted without changing its contents.

Changes: Security finding overview

Layer / File(s) Summary
Finding badge and overview rendering
apps/web/src/page/security/kit/findings-view.ts, apps/web/src/page/security/tabs/view-overview.ts
The shared findings view adds a dashed-outline badge for a finding’s bucket label. The overview uses it for unverified findings and appends an unverified chip. Existing confirmed-severity rendering remains. The severity dot and count use a compact array with the same contents as before.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

Suggested labels: preview:web

Merge Risk: Minimal · up to 869cc

Open leads show estimated severity separately from the Unverified chip. No merge-blocking risk was identified.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Makisuo
Makisuo merged commit fd1c3fa into main Nov 10, 2026
22 of 28 checks passed
@Makisuo
Makisuo deleted the fix/security-open-leads-badge branch November 10, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant