Skip to content

feat(audit-log): icons for actions, actors, surfaces and outcomes - #2433

Merged
Makisuo merged 27 commits into
mainfrom
audit-log-ui/d-icons
Nov 10, 2026
Merged

Makisuo merged 27 commits into
mainfrom
audit-log-ui/d-icons

Merge branch 'main' into audit-log-ui/d-icons

d28aeb9
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 10, 2026 in 1m 51s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. Presentational change confined to the audit-log view and two optional kit props; the kickoff's "changed since" list named unrelated files, so pr_changed_files' five files were the review.
no findings · tests not needed · risk low

Adds glyphs across the audit log — row actions, actor/source/outcome badges, filters, entry detail and day headings — from a verb table the types keep exhaustive, and rebalances the row columns to make room. View-only; safe to merge.

  • auditActionIcon picks a glyph from the action's verb, a bolt for an unknown one
  • eyebrow and attributeFilterAction gained an optional icon
  • The resource column shares the row's spare width with the action
  • The source column moves from @xl to @2xl, the lookup field takes leftover space
What was checked
  • All 41 icon names used resolve in icons.generated.ts; badge and toggle styles size an unclassed svg, so glyphs do not change control height
  • SOURCE_ICONS[entry.source] cannot miss: source decodes as AuditLogSource literals (packages/domain/src/http/audit-log.ts:22)
  • Select leading renders before the value span (select-view.ts:329), so a chosen value keeps its filter glyph

d28aeb9 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.