You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(audit-log): icons for actions, actors, surfaces and outcomes - #2433
Follow-up to the audit log UI polish. Stacked on #2424.
The log was all text: every row, badge and filter had to be read to be told apart. Now each kind of thing has a glyph, and a filter carries the same glyph as the badges it filters by.
Rows lead the action with a glyph for its verb: created, updated, deleted, rolled, revoked, read, tool call, SQL, API request, and so on. On a refused entry the glyph is red, next to the red edge.
Actor, source and outcome badges have glyphs (API key, agent, system; dashboard, API, MCP, chat; allowed, denied).
Filters: the kind switch, actor type and outcome options, and the person, resource, action and affected-user selects each lead with a glyph, so a select still says what it filters once a value replaces its label.
Entry detail: glyphs on the Origin, Changes and Details headings, the surface, the "Filter" pivots and "Link to entry".
Day headings have a calendar glyph.
Kit: eyebrow and attributeFilterAction take an icon option. Nothing changes for callers that pass none.
The verb table in audit-log/icons.ts is checked against AuditResources, so a new verb fails the build until it has a glyph. An action this build does not know gets the bolt.
Layout, because the glyphs take width:
The resource column shares the row's spare width with the action instead of holding a fixed 14rem. The action label used to collapse to about 70px where that column appears; it now keeps about half the spare width.
The lookup field takes the space the filters leave and drops to its own row only when that is too little to type in.
The source column appears one step later, so the action keeps its room at mid widths.
audit-log.scene.test.ts (20) and the attributes panel scene tests (6) pass: every accessible name the tests and screen readers use is unchanged, the glyphs are aria-hidden.
apps/web typechecks; oxlint with the CI config is clean; ui:patterns:check and ui:index:check OK; the ui-kit baseline is unchanged (724).
Checked in the lab (/lab/audit-log) at 390, 560, 900, 1090, 1200 and 1280px, in the Changes, Data access, All, filtered, expanded and unknown-lookup states.
Not run: a preview deploy. The change is view-only and the lab covers every state.
…lookup filters
The audit log listed every telemetry read and MCP tool call beside the
changes, so the entries an admin opens the page for were buried. The list
now opens on Changes (data access hidden unless it was denied), with Data
access and All one click away, backed by a new kind param on
GET /v2/audit_log.
Also: resource type, action and affected user filters, a lookup field
that turns a pasted id or action into its filter, chips for filters with
no control of their own, a working Custom range, and a /lab/audit-log
page over fixtures.
…ere it came from
Following a trail meant copying an id and pasting it back as a filter.
Every actor, action, resource, affected user and request in an entry's
detail now has a Filter action that lists every entry with that value.
Also: unnamed actors and membership changes show the member's name, a
new Origin section shows surface, IP, country and request, metadata keys
read as labels, and each entry has a link that opens the log on it
(?entry=alog_...) and scrolls it into view.
inlineCode gains size and tone options; the audit log detail and the
alerts hub empty state move onto them, clearing 6 ui-kit baseline
violations.
The list was one undifferentiated column of relative times. Rows now sit
under Today / Yesterday / date headings counted in the viewer's zone,
a denied entry carries a red left edge, and in the All view allowed
reads, tool calls and SQL runs are muted so changes stand out. The
Source column shows from a narrower width.
dayLabel/dayKey move from the users detail into page/kit/day-label so
both pages share them. The audit log list clears its last 3 ui-kit
baseline violations.
… minute was
The link listed the minute around the entry, newest first, so 50 newer
entries pushed it to page 2 where it never opened. The window now ends
at the entry, which therefore heads the first page, and a later page
holding it reveals it too.
The web muted reads with its own copy of the server's access suffixes,
so a new access action would be filtered but not muted. The list and an
isAuditAccessAction helper move to @maple/domain/audit-actions; the
backend re-exports it for existing importers.
… and the outcome
Each row leads its action with a glyph for the verb (created, updated, deleted, rolled, read,
tool call, SQL, API request), and the filters carry the same glyphs as the badges they filter by.
The eyebrow and the Filter action take an icon option.
…verb has a glyph
The resource column shares the row's spare width with the action instead of holding a fixed 14rem,
so the label no longer collapses where the column appears. The verb table is total, so a new verb
fails the build until it has a glyph. One actor badge and one denied badge for the rows and the
detail, and an eyebrow with an icon stays block-level on a heading.
No actionable comments were generated in the recent review.
Walkthrough
The audit-log views now use typed icon mappings in filters, list entries, and detail fields. Shared attribute-filter actions and eyebrow components also support optional icons.
MapleTechLabs/maple#1930: Adds status-page audit actions that receive icons from the verb mapping in this pull request.
MapleTechLabs/maple#2290: Adds alert-silence audit actions that receive icons from the verb mapping in this pull request.
Suggested labels:preview:web
Suggested reviewers:jeremyfunk
Merge Risk: Minimal · up to d28ae
The reviewed audit-log icon changes have no identified merge-blocking issue. The checked controls retain their accessible names.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly summarizes the main change: adding icons across audit-log actions, actors, sources, and outcomes.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 5 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
The Origin section was skipped when an entry had no IP, country or request id, which also hid the
surface it always has. Adds a test for that, and one for the window an entry's link opens.
…e-minute window
An entry link lists the minute ending at its entry. A pivot kept that custom range, so "every
entry with this actor" listed only that minute.
🟢 Confidence 10/10 · safe to merge. Presentational change confined to the audit-log view and two optional kit props; the kickoff's "changed since" list named unrelated files, so pr_changed_files' five files were the review. no findings · tests not needed · risk low
Adds glyphs across the audit log — row actions, actor/source/outcome badges, filters, entry detail and day headings — from a verb table the types keep exhaustive, and rebalances the row columns to make room. View-only; safe to merge.
auditActionIcon picks a glyph from the action's verb, a bolt for an unknown one
eyebrow and attributeFilterAction gained an optional icon
The resource column shares the row's spare width with the action
The source column moves from @xl to @2xl, the lookup field takes leftover space
d28aeb9 · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the audit log UI polish. Stacked on #2424.
The log was all text: every row, badge and filter had to be read to be told apart. Now each kind of thing has a glyph, and a filter carries the same glyph as the badges it filters by.
Kit:
eyebrowandattributeFilterActiontake aniconoption. Nothing changes for callers that pass none.The verb table in
audit-log/icons.tsis checked againstAuditResources, so a new verb fails the build until it has a glyph. An action this build does not know gets the bolt.Layout, because the glyphs take width:
Before / after
Close up:
Verification
audit-log.scene.test.ts(20) and the attributes panel scene tests (6) pass: every accessible name the tests and screen readers use is unchanged, the glyphs arearia-hidden.apps/webtypechecks; oxlint with the CI config is clean;ui:patterns:checkandui:index:checkOK; the ui-kit baseline is unchanged (724)./lab/audit-log) at 390, 560, 900, 1090, 1200 and 1280px, in the Changes, Data access, All, filtered, expanded and unknown-lookup states.Stack: #2422 → #2423 → #2424 → this
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit